Repository navigation
Move embedding tests to their own test module #76317
Description
| BPO | 32136 |
|---|---|
| Nosy | @ncoghlan, @vstinner, @ericsnowcurrently, @zooba |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2017-11-27.22:12:15.292>
created_at = <Date 2017-11-26.04:37:15.680>
labels = ['3.7', '3.8', 'type-feature', 'tests']
title = 'Move embedding tests to their own test module'
updated_at = <Date 2017-11-27.22:12:15.292>
user = 'https://github.com/ncoghlan'bugs.python.org fields:
activity = <Date 2017-11-27.22:12:15.292>
actor = 'ncoghlan'
assignee = 'none'
closed = True
closed_date = <Date 2017-11-27.22:12:15.292>
closer = 'ncoghlan'
components = ['Tests']
creation = <Date 2017-11-26.04:37:15.680>
creator = 'ncoghlan'
dependencies = []
files = []
hgrepos = []
issue_num = 32136
keywords = ['patch']
message_count = 6.0
messages = ['306988', '306990', '306996', '307003', '307045', '307098']
nosy_count = 4.0
nosy_names = ['ncoghlan', 'vstinner', 'eric.snow', 'steve.dower']
pr_nums = ['4567']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue32136'
versions = ['Python 3.7', 'Python 3.8']
Activity
ncoghlan commentedon Nov 26, 2017
We currently run the runtime embedding tests as a subsection of "test_capi".
I'm thinking it may make more sense to clearly separate them out as their own CPython-only test file, "test_runtime_embedding".
I'm also thinking we should add a new "Runtime embedding" entry to the experts index, with myself, Victor Stinner, Eric Snow, and Steve Dower as the initial members.
ncoghlan commentedon Nov 26, 2017
As noted in https://bugs.python.org/issue32096#msg306989, it would also be good to ensure that the full traceback from a failed
_testembedcall is always visible when running in verbose mode.vstinner commentedon Nov 26, 2017
What about a shorter name like test_embed?
ncoghlan commentedon Nov 26, 2017
I guess the shorted name would also better match the naming scheme used for the C API test module:
Modules/_testcapi.c -> Lib/test/test_capi.py
Progams/_testembed.c -> Lib/test/test_embed.py
vstinner commentedon Nov 27, 2017
I like it :-)
ncoghlan commentedon Nov 27, 2017
New changeset 39f0bb5 by Nick Coghlan in branch 'master':
bpo-32136: Separate embedding tests from C API tests (GH-4567)
39f0bb5