You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Compile error on Python/ceval.c without threads #75037
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee=Noneclosed_at=<Date2017-07-05.09:25:12.100>created_at=<Date2017-07-05.07:53:20.494>labels= ['build', '3.7']
title='Compile error on Python/ceval.c without threads'updated_at=<Date2017-07-05.13:44:55.781>user='https://github.com/ma8ma'
New changeset e3a0ff0 by Victor Stinner (Masayuki Yamamoto) in branch '3.6':
[3.6] bpo-30854: Fix compile error when --without-threads (GH-2581) (bpo-2583) e3a0ff0
Activity
ma8ma commentedon Jul 5, 2017
I found a syntax error when compiling without threads.
In that place, the colon has been used instead of semicolon at end of statement.
build commands and error log:
$ uname -a
Linux masayuki-P35-DS3 4.4.0-83-generic #106-Ubuntu SMP Mon Jun 26 17:54:25 UTC 2017 i686 i686 i686 GNU/Linux
$ git checkout master
$ ./configure --without-threads && LC_ALL=C make -j2
(snip)
gcc -c -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter -Wno-missing-field-initializers -Werror=implicit-function-declaration -I. -I./Include -DPy_BUILD_CORE -o Python/ceval.o Python/ceval.c
Python/ceval.c: In function 'Py_MakePendingCalls':
Python/ceval.c:551:23: error: expected ';' before ':' token
goto error:
^
Makefile:1551: recipe for target 'Python/ceval.o' failed
make: *** [Python/ceval.o] Error 1
related changeset:
3024c05 [3.6] bpo-30703: Improve signal delivery (GH-2415) (bpo-2527)
c08177a bpo-30703: Improve signal delivery (bpo-2415)
I open one line change PR that replaces colon with semicolon for master branch right away.
vstinner commentedon Jul 5, 2017
New changeset 0c31163 by Victor Stinner (Masayuki Yamamoto) in branch 'master':
bpo-30854: Fix compile error when --without-threads (bpo-2581)
0c31163
[-]Compile error on Python/ceval.c[/-][+]Compile error on Python/ceval.c without threads[/+]vstinner commentedon Jul 5, 2017
New changeset e3a0ff0 by Victor Stinner (Masayuki Yamamoto) in branch '3.6':
[3.6] bpo-30854: Fix compile error when --without-threads (GH-2581) (bpo-2583)
e3a0ff0
vstinner commentedon Jul 5, 2017
Thanks Masayuki Yamamoto for your fixes!
vstinner commentedon Jul 5, 2017
New changeset 8207c17 by Victor Stinner in branch 'master':
Revert "bpo-30822: Fix testing of datetime module." (bpo-2588)
8207c17