Repository navigation
IDLE parenmatch - highlighting options #74992
Description
| BPO | 30809 |
|---|---|
| Nosy | @terryjreedy, @taleinat, @wohlganger |
| PRs | |
| Dependencies |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2019-06-06.19:33:38.414>
created_at = <Date 2017-06-29.20:36:07.899>
labels = ['expert-IDLE', 'type-feature', '3.7']
title = 'IDLE parenmatch - highlighting options'
updated_at = <Date 2019-06-06.19:33:38.413>
user = 'https://github.com/wohlganger'bugs.python.org fields:
activity = <Date 2019-06-06.19:33:38.413>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2019-06-06.19:33:38.414>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2017-06-29.20:36:07.899>
creator = 'wohlganger'
dependencies = ['27099']
files = []
hgrepos = []
issue_num = 30809
keywords = ['patch']
message_count = 11.0
messages = ['297317', '297340', '297404', '297442', '297443', '297446', '297452', '297905', '300827', '344848', '344859']
nosy_count = 3.0
nosy_names = ['terry.reedy', 'taleinat', 'wohlganger']
pr_nums = ['3574']
priority = 'low'
resolution = 'rejected'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue30809'
versions = ['Python 3.6', 'Python 3.7']
Activity
wohlganger commentedon Jun 29, 2017
Current IDLE parenmatch highlighting uses the 'hilite' style when highlighting the parens/expression.
Desired behavior is to use a user-setting based style that is independent from the hilite style (which is used for highlighting selected text). Desired selectable options are for foreground color, background color, underlining and font (which covers font type, size, bold, and italics)
Apart from running IDLE and checking that the selections match, I don't know how to test. Testing would need a human to check for correct colors, etc. if it was made, so it couldn't be automated...
terryjreedy commentedon Jun 30, 2017
I am not willing to add a new theme element to the 13 that already exist, let alone define it in config-extensions.def rather than in config-hightlight.def. It is too much additional complication for too little impact. Also, any theme specified in config-extensions would likely not work if the user switches between dark and light text. Theme sets work together.
I will consider letting users select which of the existing 13 to use. This requires that users be able to know what the 13 choices are. Hence the dependence on bpo-22705.
I might also look at the visual effect of underlining.
wohlganger commentedon Jun 30, 2017
The pull request has been changed to only have the theme element able to be selected. bpo-22705 hasn't had activity in a few years. Is there something I can do to move it along?
terryjreedy commentedon Jun 30, 2017
As far as you want to go with
Or skip this if you make PR and review on github.
terryjreedy commentedon Jun 30, 2017
There is another option. I want to incorporate 'builtin extensions' as regular features (bpo-27099), and move their configuration options to other tabs, which will need some reworking. bpo-22705 will then be less urgent. Selection from a finite set will then be from a dropdown box, like similar non-extension options. Thus bpo-27099, which waiting on current work in process on ConfigDialog, is an alternate dependency.
wohlganger commentedon Jun 30, 2017
Implimenting bpo-27099 seems the more reasonable solution to me, so I'll work on that when I have free time.
terryjreedy commentedon Jun 30, 2017
Since configdialog code is being re-written, I would not want to write code right now. But we could start planning.
wohlganger commentedon Jul 7, 2017
I've rolled pretty much all this was going to do, other than underlining and font work into bpo-27099. Trying to bring parenmatch into main otherwise would have been just as much of a hassle.
terryjreedy commentedon Aug 25, 2017
As I said on bpo-27099, please do not include new options with the transfer patch.
taleinat commentedon Jun 6, 2019
FWIW I'm -1 on this change, due to the decision to keep IDLE simple for new users learning Python rather than power users.
terryjreedy commentedon Jun 6, 2019
I agree. The parenmatch highlighting is so transient that it hardly matters what it is, except that it should not match a syntax color.