Repository navigation
Pull Windows dependencies from GitHub rather than svn.python.org #74635
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/zooba'
closed_at = <Date 2017-12-06.21:14:23.747>
created_at = <Date 2017-05-24.01:33:46.861>
labels = ['extension-modules', 'build', '3.7', 'OS-windows', 'performance']
title = 'Pull Windows dependencies from GitHub rather than svn.python.org'
updated_at = <Date 2017-12-06.22:28:17.743>
user = 'https://github.com/zware'bugs.python.org fields:
activity = <Date 2017-12-06.22:28:17.743>
actor = 'vstinner'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2017-12-06.21:14:23.747>
closer = 'zach.ware'
components = ['Build', 'Extension Modules', 'Windows']
creation = <Date 2017-05-24.01:33:46.861>
creator = 'zach.ware'
dependencies = []
files = []
hgrepos = []
issue_num = 30450
keywords = ['patch']
message_count = 52.0
messages = ['294307', '294359', '294441', '294494', '294533', '294534', '295240', '296150', '296157', '296160', '296351', '296365', '296805', '298469', '298471', '298476', '298497', '298498', '298501', '298504', '298505', '298506', '298507', '298508', '298509', '298512', '298513', '298516', '298517', '298518', '298519', '298520', '298522', '298523', '298526', '298552', '298557', '298559', '298560', '298608', '298609', '298640', '299803', '299809', '301279', '301327', '301328', '301365', '301712', '301966', '307769', '307772']
nosy_count = 11.0
nosy_names = ['paul.moore', 'pitrou', 'vstinner', 'tim.golden', 'benjamin.peterson', 'jkloth', 'jeremy.kloth', 'zach.ware', 'steve.dower', 'ammar2', 'schen']
pr_nums = ['1783', '2236', '2237', '2737', '2739', '2744', '2751', '3306', '3330', '3348', '3443']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue30450'
versions = ['Python 2.7', 'Python 3.5', 'Python 3.6', 'Python 3.7']
Activity
zware commentedon May 24, 2017
Once we've migrated away from svn.python.org for Windows build dependencies, there should be no reason to continue running svn.python.org.
zooba commentedon May 24, 2017
The reason to keep it running is for all the existing people who are building from source. Unless you're porting all the old versions over and providing instructions for updating old sources? I wouldn't bother - just leave the server up for a few more years.
Ben probably knows - can we add a custom message to svn requests? Then we could start publicising an end of life date for it.
benjaminp commentedon May 25, 2017
The box svn is running on is at risk of falling over any day. Plus with whatever ancient software it's running, it's surely a security risk to keep running an unmaintained svn instance. I certainly don't want to keep it running for years. I don't think we've ever advertised the svn windows deps as a service we provide the community.
Off the top of my head, I'm not sure how to announce that deprecation to svn client users. If you find something on the internets, I can put it on the server.
zooba commentedon May 25, 2017
Except in the dev guide :) ([after looking] well, linked from the dev guide https://github.com/python/cpython/blob/master/PCbuild/readme.txt#L230 )
Maybe we just need to pick a date and publicise it separately. Is this process PEP-worthy? Considering the amount of decisions we had to make regarding putting code in git, it might be worth writing up how it works in a brief PEP and including an EOL for svn.p.o
benjaminp commentedon May 26, 2017
How far along are you with removing the svn.python.org dependency. Does Jan 1 2018 sound okay for the end of svn.python.org?
I think a PEP is up to you. Doesn't seem like something that needs to be approved.
pitrou commentedon May 26, 2017
I could imagine people wanting to build old releases. But we have Windows binaries up here:
https://www.python.org/ftp/python/
Therefore I don't think it's a problem to discontinue svn.python.org once new releases are migrated to github (but only once those new releases are out).
benjaminp commentedon Jun 6, 2017
I just disabled viewvc on svn.python.org because of a security problem.
zware commentedon Jun 16, 2017
New changeset 51599e2 by Zachary Ware in branch 'master':
bpo-30450: Pull Windows dependencies from GitHub rather than svn (GH-1783)
51599e2
zware commentedon Jun 16, 2017
New changeset cb8c048 by Zachary Ware in branch 'master':
bpo-30450: Add NEWS and whatsnew (GH-2236)
cb8c048
34 remaining items
zooba commentedon Jul 18, 2017
New changeset 5feda33 by Steve Dower in branch 'master':
bpo-30450: Fix logic for retrying nuget.exe download (bpo-2744)
5feda33
zooba commentedon Jul 18, 2017
Zach - did this get backported to 2.7 or 3.5? It doesn't look like it.
zooba commentedon Jul 19, 2017
New changeset e99d3a5 by Steve Dower in branch '3.6':
[3.6] bpo-30450: Improved logic for obtaining dependencies (bpo-2751)
e99d3a5
pitrou commentedon Aug 6, 2017
Has this actually been backported to 3.6? It looks like a lot of Tcl and OpenSSL stuff is being compiled on AppVeyor yet:
https://ci.appveyor.com/project/python/cpython/build/3.6.1+.5134
zooba commentedon Aug 6, 2017
The prebuilt binaries have not, and the OpenSSL change has functional implications and should not be (unless someone wants to make the security justification, but right now I think it's a theoretical rather than an actual benefit). The TclTk build could be, but I haven't gone to the effort to split it up.
There's also a separate issue for that part - this bug is for the location of sources.
zware commentedon Sep 4, 2017
New changeset 986b7ff by Zachary Ware in branch '2.7':
[2.7] bpo-30450: Pull Windows dependencies from GitHub rather than SVN (GH-1783) (GH-3306)
986b7ff
vstinner commentedon Sep 5, 2017
This change broke Python 2.7 compilation on Windows XP.
Pending fix: PR 3330.
vstinner commentedon Sep 5, 2017
This change also broke compilation on AMD64 Windows10 2.7 buildbot:
http://buildbot.python.org/all/builders/AMD64%20Windows10%202.7/builds/279
"D:\buildarea\2.7.bolen-windows10\build\PCbuild\pcbuild.proj" (Build target) (1) ->
"D:\buildarea\2.7.bolen-windows10\build\PCbuild\pythoncore.vcxproj" (Build target) (2) ->
(Manifest target) ->
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\Microsoft.CppCommon.targets(574,5): error MSB6006: "mt.exe" exited with code -1073741819. [D:\buildarea\2.7.bolen-windows10\build\PCbuild\pythoncore.vcxproj]
zware commentedon Sep 5, 2017
New changeset 8905fb8 by Zachary Ware in branch '2.7':
bpo-30450: Don't use where, XP doesn't have it (GH-3348)
8905fb8
zware commentedon Sep 8, 2017
New changeset 1911cf3 by Zachary Ware in branch '2.7':
[2.7] bpo-30450: Fall back on the old env.bat (GH-3443)
1911cf3
vstinner commentedon Sep 12, 2017
I created the bug bpo-31430 to track this regression.
zware commentedon Dec 6, 2017
This has been backported and working for nearly 3 months now; closing.
As for whether to continue operating svn.python.org now that we're officially away from it: that can be determined elsewhere, probably by the box dying and deciding for us :)
vstinner commentedon Dec 6, 2017
Noooo! I loved Subversion so much! ... just kidding. Thanks for getting rid of Subversion.
It became much easier to build CPython on Windows nowadays!