Repository navigation
Missed reference to create_module() in versionadded (import.rst) #73834
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2017-02-26.15:41:55.679>
created_at = <Date 2017-02-25.11:22:08.905>
labels = ['3.7', 'docs']
title = 'Missed reference to create_module() in versionadded (import.rst)'
updated_at = <Date 2017-03-24.23:42:22.346>
user = 'https://github.com/marco-buttu'bugs.python.org fields:
activity = <Date 2017-03-24.23:42:22.346>
actor = 'Mariatta'
assignee = 'docs@python'
closed = True
closed_date = <Date 2017-02-26.15:41:55.679>
closer = 'Mariatta'
components = ['Documentation']
creation = <Date 2017-02-25.11:22:08.905>
creator = 'marco.buttu'
dependencies = []
files = []
hgrepos = []
issue_num = 29648
keywords = []
message_count = 7.0
messages = ['288560', '288572', '288596', '288597', '290385', '290387', '290392']
nosy_count = 6.0
nosy_names = ['brett.cannon', 'ncoghlan', 'docs@python', 'eric.snow', 'marco.buttu', 'Mariatta']
pr_nums = ['277', '290', '314', '315']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue29648'
versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']
Activity
marco-buttu commentedon Feb 25, 2017
In the first
versionaddedof the Loader section [1] of Doc/reference/import.rst, there is no reference tocreate_module():.. versionadded:: 3.4
The create_module() method of loaders.
It should be:
.. versionadded:: 3.4
The :meth:`~importlib.abc.Loader.create_module` method of loaders.
I will make a PR.
[1] https://docs.python.org/3/reference/import.html#loaders
Mariatta commentedon Feb 25, 2017
Thanks, Marco. Your change looks good to me.
I'm now wondering if this should have been 'versionchanged' instead of 'versionadded'. Perhaps other core devs can confirm this.
Thanks :)
ncoghlan commentedon Feb 26, 2017
Version added is correct here, as the "create_module()" methods are all new in 3.4, and the traditional granularity for deciding "addition or change?" is that new functions, methods, and attributes are always additions, even if they're being added to a class definition.
Mariatta commentedon Feb 26, 2017
Thanks for the clarification, Nick :)
Marco, I merged your PR, and backported to 3.5 and 3.6 branches.
Thanks!
Mariatta commentedon Mar 24, 2017
New changeset 63ed9bc by Mariatta in branch '3.5':
bpo-29648: import.rst: Add reference to create_module() (GH-290) (GH-315)
63ed9bc
Mariatta commentedon Mar 24, 2017
New changeset 7333d17 by Mariatta in branch '3.6':
bpo-29648: import.rst: Add reference to create_module() (GH-290) (GH-314)
7333d17
Mariatta commentedon Mar 24, 2017
New changeset 46ce759 by Mariatta (Marco Buttu) in branch 'master':
bpo-29648: import.rst: Add reference to create_module() (GH-290)
46ce759