Repository navigation
_decimal difference with _pydecimal #73720
Description
Activity
arigo commented
on Feb 11, 2017 arigomannequinMannequinAuthorA difference in behavior between _decimal and _pydecimal (it seems that _decimal is more consistent in this case):
class X(Decimal): def __init__(self, a): print('__init__:', a) X.from_float(42.5) # __init__: Decimal('42.5') X.from_float(42) # with _pydecimal: __init__: 42 # with _decimal: __init__: Decimal('42')
skrah commented
on Feb 11, 2017 skrahmannequinMannequinI get the the same output, perhaps I misunderstand something here:
>>> from _decimal import * >>> class X(Decimal): ... def __init__(self, a): ... print('__init__:', a) ... >>> X.from_float(42.5) __init__: 42.5 Decimal('42.5') >>> X.from_float(42) __init__: 42 Decimal('42') >>> >>> >>> from _pydecimal import * >>> class X(Decimal): ... def __init__(self, a): ... print('__init__:', a) ... >>> X.from_float(42.5) __init__: 42.5 Decimal('42.5') >>> X.from_float(42) __init__: 42 Decimal('42')
arigo commented
on Feb 11, 2017 arigomannequinMannequinAuthorSorry! It should be repr(a) inside the print. Here is the fixed version:
class X(Decimal): def __init__(self, a): print('__init__:', repr(a)) X.from_float(42.5) # __init__: Decimal('42.5') X.from_float(42) # with _pydecimal: __init__: 42 # with _decimal: __init__: Decimal('42')
andrewnester commented
on Feb 13, 2017 andrewnestermannequinMannequinI've just added PR for this issue.
Is there an observable difference in user behaviour if no subclassing of Decimal is involved? Or does this just affect Decimal subclasses?
BTW, as a user, I'd expect
Decimal.from_floatto simply coerce its input to float if given an input that isn't actually a float in the first place; the fact that it has special handling in place for int inputs (and that that special handling takes the form of an isinstance check, rather than something more duck-typed) is surprising.andrewnester commented
on Feb 13, 2017 andrewnestermannequinMannequinactually, it's more related to subclassing, because the problem comes from the fact that before the fix __init__ method receives value as int not Decimal if int passed to from_float call.
That's why only subclasses of Decimal can see difference in arguments received by __init__andrewnester commented
on Feb 13, 2017 andrewnestermannequinMannequinAgree about surprising behaviour but I guess it's better to fix it as other issue because it could break BC in some cases. At least it needs to be investigated.
For now I would like to stick with same behaviour for _decimal and _pydecimal
[Andrew]
it's better to fix it as other issue
No, it's better not to "fix" it at all. :-) It's one of those many behaviour changes where the answer to "Should we have done this differently in the first place" might possibly be "Yes" (and might also be "No"), but the answer to "Should we *change* it now" is a definite "No" (especially given that the "from_float" method is there almost entirely for backwards compatibility). I shouldn't have brought it up. Apologies.
andrewnester commented
on Feb 13, 2017 andrewnestermannequinMannequinthanks for your notes, it's absolutely fine and I agree with you :)
PR merged; thank you!
Unfortunately, just after I merged it I noticed that the Misc/NEWS entry was in the wrong section. I'll make a new PR to fix that, and close this issue once it's done.
All done. Closing. (In theory, as a bugfix, this could be backported to 3.5 and 3.6. In practice, I doubt it's worth the effort.)
skrah commented
on Mar 31, 2017 skrahmannequinMannequinDoes anyone know how to disable the spurious pull requests that keep coming in?
Misc/NEWSso that it is managed by towncrier #552Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields: