Skip to content

Curses Module should check for is_keypad and not window flags #73356

Description

@RoyMarples
mannequin
BPO 29170
Nosy @ma8ma
Superseder
  • bpo-25720: Fix curses module compilation with ncurses6
  • Files
  • cursesmodule.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2017-01-05.22:36:57.965>
    created_at = <Date 2017-01-05.21:57:30.738>
    labels = ['extension-modules', 'build']
    title = 'Curses Module should check for is_keypad and not window flags'
    updated_at = <Date 2017-01-06.02:17:02.782>
    user = 'https://bugs.python.org/RoyMarples'

    bugs.python.org fields:

    activity = <Date 2017-01-06.02:17:02.782>
    actor = 'berker.peksag'
    assignee = 'none'
    closed = True
    closed_date = <Date 2017-01-05.22:36:57.965>
    closer = 'Roy Marples'
    components = ['Extension Modules']
    creation = <Date 2017-01-05.21:57:30.738>
    creator = 'Roy Marples'
    dependencies = []
    files = ['46163']
    hgrepos = []
    issue_num = 29170
    keywords = ['patch']
    message_count = 4.0
    messages = ['284771', '284775', '284777', '284779']
    nosy_count = 2.0
    nosy_names = ['masamoto', 'Roy Marples']
    pr_nums = []
    priority = 'normal'
    resolution = 'duplicate'
    stage = 'resolved'
    status = 'closed'
    superseder = '25720'
    type = 'compile error'
    url = 'https://bugs.python.org/issue29170'
    versions = ['Python 3.6']

    Activity

    1. RoyMarples commented on Jan 5, 2017

      RoyMarplesmannequin
      MannequinAuthor

      checking whether WINDOW has _flags... no

      The ncurses library can be built with an opaque window structure.
      As such, it's not always possible to query it's flags.
      Luckily there is the is_keypad function which works regardless of how ncurses was built.

      If this test is changed, then it will help support NetBSD curses as well.

    2. RoyMarples commented on Jan 5, 2017

      RoyMarplesmannequin
      MannequinAuthor

      Remove WINDOW test
      Add is_keypad test
      Change #define in _cursesmodule.c

    3. ma8ma commented on Jan 5, 2017

      ma8mamannequin
      Mannequin

      bpo-25720 is a similar issue that is originated by opaque type WINDOW.

    4. RoyMarples commented on Jan 5, 2017

      RoyMarplesmannequin
      MannequinAuthor

      It is, sorry for noise.

    5. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      buildThe build process and cross-buildextension-modulesC modules in the Modules dir

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions