sqlite3 Controlling Transactions documentation not updated

@berkerpeksag

BPO	29121
Nosy	@berkerpeksag, @serhiy-storchaka, @animalize, @palaviv
PRs	bpo-29121: Remove outdated documentation about transactions #313 [3.6] bpo-29121: Remove outdated documentation about transactions (#313) #319
Files	sqlite-transaction-doc.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2017-02-26.16:04:48.886>
created_at = <Date 2016-12-31.16:04:55.057>
labels = ['type-bug', '3.7', 'docs']
title = 'sqlite3 Controlling Transactions documentation not updated'
updated_at = <Date 2017-03-24.23:41:51.182>
user = 'https://github.com/palaviv'

bugs.python.org fields:

activity = <Date 2017-03-24.23:41:51.182>
actor = 'berker.peksag'
assignee = 'docs@python'
closed = True
closed_date = <Date 2017-02-26.16:04:48.886>
closer = 'berker.peksag'
components = ['Documentation']
creation = <Date 2016-12-31.16:04:55.057>
creator = 'palaviv'
dependencies = []
files = ['46101']
hgrepos = []
issue_num = 29121
keywords = ['patch']
message_count = 7.0
messages = ['284396', '286217', '286293', '288598', '290379', '290388', '290389']
nosy_count = 6.0
nosy_names = ['ghaering', 'docs@python', 'berker.peksag', 'serhiy.storchaka', 'malin', 'palaviv']
pr_nums = ['313', '319']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue29121'
versions = ['Python 3.6', 'Python 3.7']

commit 284676cf2ac8 changed the sqlite3 module so it will no longer implicitly commit an open transaction before DDL statements. The docs have been updated but there is still an incorrect paragraph that has not been removed.
Attached is a patch that remove the old paragraph.

I would just like to note that I think that the correct solution is to do an implicit commit before:

VACUUM
ATTACH
DETACH
BEGIN

After read some issues, there are two major concerns:
1, backward compatibility.
2, implicit commit is bad, tolerates bug-prone codes.

However they are not contradictory if we print a warning when doing an implicit commit. Some messages like this:
Warning: sqlite3 module issued an implicit commit before executing VACUUM, you should commit this transaction by yourself, that's a good habit, etc..

Then we can keep backward compatibility, and no longer commit implicitly.

Thanks for the patch, Aviv!

New changeset 893e86e by Berker Peksag in branch '3.6':
bpo-29121: Remove outdated documentation about transactions (#313) (#319)
893e86e

New changeset fe70d92 by Berker Peksag in branch 'master':
bpo-29121: Remove outdated documentation about transactions (#313)
fe70d92

Navigation Menu

Repository navigation

sqlite3 Controlling Transactions documentation not updated #73307

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

sqlite3 Controlling Transactions documentation not updated #73307

Description

Activity

palaviv commented on Dec 31, 2016

palaviv commented on Jan 24, 2017

animalize commented on Jan 26, 2017

berkerpeksag commented on Feb 26, 2017

berkerpeksag commented on Mar 24, 2017

berkerpeksag commented on Mar 24, 2017

berkerpeksag commented on Mar 24, 2017

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions