Repository navigation
Reduce marshal stack depth for 2.7 on Windows debug build #71206
Description
| BPO | 27019 |
|---|---|
| Nosy | @db3l, @benjaminp, @zooba |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2016-07-07.06:37:15.662>
created_at = <Date 2016-05-14.16:41:41.344>
labels = ['tests']
title = 'Reduce marshal stack depth for 2.7 on Windows debug build'
updated_at = <Date 2016-07-07.06:37:15.660>
user = 'https://github.com/db3l'bugs.python.org fields:
activity = <Date 2016-07-07.06:37:15.660>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2016-07-07.06:37:15.662>
closer = 'python-dev'
components = ['Tests']
creation = <Date 2016-05-14.16:41:41.344>
creator = 'db3l'
dependencies = []
files = ['42849']
hgrepos = []
issue_num = 27019
keywords = ['patch']
message_count = 2.0
messages = ['265533', '269922']
nosy_count = 4.0
nosy_names = ['db3l', 'benjamin.peterson', 'python-dev', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue27019'
versions = ['Python 2.7']
Activity
db3l commentedon May 14, 2016
I'd like to propose backporting the change in bpo-22734 to the 2.7 branch. The marshal recursion depth appears to be at the root of the failures of the Windows 8 and 10 buildbots in test_marshal on that branch, which is still using a depth of 2000.
The one thing I haven't yet been able to figure out is why this only seems to happen under Windows 8/10, and not 7/XP, but I don't think the change is harmful in any case.
The attached patch, adapted from bpo-22734 is against the current 2.7 tip.
python-dev commentedon Jul 7, 2016
New changeset 6230ead06f65 by Benjamin Peterson in branch '2.7':
reduce marshal stack size in debug mode on windows (closes bpo-27019)
https://hg.python.org/cpython/rev/6230ead06f65