Repository navigation
Argument Clinic: generate code into separate files by default #67689
Description
| BPO | 23501 |
|---|---|
| Nosy | @larryhastings, @serhiy-storchaka |
| Dependencies | |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2015-04-03.20:54:56.726>
created_at = <Date 2015-02-22.11:04:48.510>
labels = ['type-feature', 'expert-argument-clinic', 'build']
title = 'Argument Clinic: generate code into separate files by default'
updated_at = <Date 2015-04-04.21:48:51.971>
user = 'https://github.com/serhiy-storchaka'bugs.python.org fields:
activity = <Date 2015-04-04.21:48:51.971>
actor = 'BreamoreBoy'
assignee = 'none'
closed = True
closed_date = <Date 2015-04-03.20:54:56.726>
closer = 'serhiy.storchaka'
components = ['Build', 'Demos and Tools', 'Argument Clinic']
creation = <Date 2015-02-22.11:04:48.510>
creator = 'serhiy.storchaka'
dependencies = ['23500']
files = ['38204']
hgrepos = []
issue_num = 23501
keywords = ['patch']
message_count = 7.0
messages = ['236406', '240036', '240037', '240089', '240090', '240091', '240092']
nosy_count = 4.0
nosy_names = ['larry', 'BreamoreBoy', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue23501'
versions = ['Python 3.5']
Activity
serhiy-storchaka commentedon Feb 22, 2015
Proposed patch makes Argument Clinic to generate code into separate files by default. This will help maintaining in the case of enhancements of Argument Clinic generation (such as bpo-23492). See thread on http://comments.gmane.org/gmane.comp.python.devel/151585 .
There is an issue with multiple macro definition in the posix module (see bpo-23500).
python-dev commentedon Apr 3, 2015
New changeset aa88a18a4aa1 by Serhiy Storchaka in branch 'default':
Issue bpo-23501: Argumen Clinic now generates code into separate files by default.
https://hg.python.org/cpython/rev/aa88a18a4aa1
larryhastings commentedon Apr 3, 2015
Thanks! I've been meaning to follow up on this. I think CPython should be consistent, one way or another. So I support this change.
BreamoreBoy commentedon Apr 4, 2015
I think this change in association with that in bpo-23500 is causing builds to fail on Windows.
error C2065: 'OS_STAT_METHODDEF' : undeclared identifier C:\cpython\Modules\posixmodule.c line 12083
python-dev commentedon Apr 4, 2015
New changeset 17eb29faebde by Serhiy Storchaka in branch 'default':
Issue bpo-23501: #include "clinic/posixmodule.c.h" was in the section skipped on Windows.
https://hg.python.org/cpython/rev/17eb29faebde
serhiy-storchaka commentedon Apr 4, 2015
Thank you Mark.
BreamoreBoy commentedon Apr 4, 2015
Serhiy, thank you for the quick fix :)