Repository navigation
Deprecation warnings building 3.5 Visual Studio Windows 8.1 64 bit #67639
Description
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2019-08-02.22:25:29.281>
created_at = <Date 2015-02-11.23:34:06.308>
labels = ['build', '3.7', 'OS-windows']
title = 'Deprecation warnings building 3.5 Visual Studio Windows 8.1 64 bit'
updated_at = <Date 2019-08-02.22:25:29.280>
user = 'https://bugs.python.org/BreamoreBoy'bugs.python.org fields:
activity = <Date 2019-08-02.22:25:29.280>
actor = 'steve.dower'
assignee = 'none'
closed = True
closed_date = <Date 2019-08-02.22:25:29.281>
closer = 'steve.dower'
components = ['Build', 'Windows']
creation = <Date 2015-02-11.23:34:06.308>
creator = 'BreamoreBoy'
dependencies = []
files = ['38101', '38103']
hgrepos = []
issue_num = 23451
keywords = ['patch']
message_count = 12.0
messages = ['235778', '235781', '235786', '235789', '236645', '237055', '237056', '239401', '297224', '297231', '331982', '331989']
nosy_count = 7.0
nosy_names = ['pitrou', 'vstinner', 'tim.golden', 'python-dev', 'zach.ware', 'steve.dower', 'miss-islington']
pr_nums = ['2318', '11190', '11191']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue23451'
versions = ['Python 3.7']
Activity
BreamoreBoy commentedon Feb 11, 2015
Raised as a placeholder.
BreamoreBoy commentedon Feb 11, 2015
Using Microsoft Visual Studio Express 2013 for Windows Desktop.
zooba commentedon Feb 12, 2015
Adding 'socket' nosy list, as Antoine may have a stronger opinion about changing _socket to avoid these warnings - they aren't all in Windows-exclusive code. Or I'm happy to add the suppression to the build if that's the better option.
I'll work up a patch for the GetVersion deprecations. I believe they're mostly checking for Vista, which we can assume now, so they aren't necessary.
zooba commentedon Feb 12, 2015
Patch attached.
Interesting, once you declare Vista as the minimum API set, WinSock claims to support CMSG_LEN which enables sendmsg() et al support in _socket. Since the WinSock API bears little relation to the POSIX(?) API, it doesn't build, so I've just undef'd CMSG_LEN when building socket.
zooba commentedon Feb 26, 2015
Anyone got a chance to double-check my patch for me? I think it's fine, unless someone really wants me to turn all the "#ifdef CMSG_LEN" checks into "#ifdef HAVE_CMSG" (which I *think* would require autoconf updates, which I am totally unqualified to do...)
python-dev commentedon Mar 2, 2015
New changeset 57e2549cc9a6 by Steve Dower in branch 'default':
Issue bpo-23451: Update pyconfig.h for Windows to require Vista headers and remove unnecessary version checks.
https://hg.python.org/cpython/rev/57e2549cc9a6
zooba commentedon Mar 2, 2015
The _WINSOCK_DEPRECATED_NO_WARNINGS question is still open, but the rest of the deprecations should be clear now.
python-dev commentedon Mar 27, 2015
New changeset f64d0b99d405 by Victor Stinner in branch 'default':
Issue bpo-23451, bpo-22117: Python 3.5 now requires Windows Vista or newer, so
https://hg.python.org/cpython/rev/f64d0b99d405
zooba commentedon Jun 28, 2017
New changeset 9f3bdcb by Steve Dower (Segev Finer) in branch 'master':
bpo-23451: Fix socket deprecation warnings in socketmodule.c (bpo-2318)
9f3bdcb
zooba commentedon Jun 28, 2017
There is only one deprecation warning left in current builds:
..\Modules\expat\xmlparse.c(796): warning C4996: 'getenv': This function or variable may be unsafe. Consider using _dupenv_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
vstinner commentedon Dec 17, 2018
New changeset 3ab064e by Victor Stinner in branch 'master':
bpo-23451: Update time.monotonic() documentation (GH-11190)
3ab064e
miss-islington commentedon Dec 17, 2018
New changeset c367d52 by Miss Islington (bot) in branch '3.7':
bpo-23451: Update time.monotonic() documentation (GH-11190)
c367d52