Skip to content

Missing the charset parameter in as_encoded_word() #67337

Closed
Closed
Missing the charset parameter in as_encoded_word()#67337
Labels
3.7 (EOL)end of lifestdlibStandard Library Python modules in the Lib/ directorytopic-emailtype-bugAn unexpected behavior, bug, or error

Description

@serhiy-storchaka
serhiy-storchaka
opened on Jan 2, 2015
BPO 23148
Nosy @warsaw, @bitdancer, @serhiy-storchaka, @iritkatriel

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-12-14.08:59:56.100>
created_at = <Date 2015-01-02.10:38:19.142>
labels = ['3.7', 'type-bug', 'library', 'expert-email']
title = 'Missing the charset parameter in as_encoded_word()'
updated_at = <Date 2021-12-14.08:59:56.099>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2021-12-14.08:59:56.099>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2021-12-14.08:59:56.100>
closer = 'serhiy.storchaka'
components = ['Library (Lib)', 'email']
creation = <Date 2015-01-02.10:38:19.142>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 23148
keywords = []
message_count = 7.0
messages = ['233310', '235892', '236369', '268854', '270628', '408502', '408517']
nosy_count = 5.0
nosy_names = ['barry', 'r.david.murray', 'python-dev', 'serhiy.storchaka', 'iritkatriel']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue23148'
versions = ['Python 3.5', 'Python 3.6', 'Python 3.7']

Activity

  1. serhiy-storchaka commented on Jan 2, 2015

    @serhiy-storchaka
    serhiy-storchaka
    on Jan 2, 2015
    MemberAuthor

    In Lib/email/_header_value_parser.py:460 the as_encoded_word() method is called without mandatory argument charset.

  2. serhiy-storchaka
    added
    stdlibStandard Library Python modules in the Lib/ directory
    topic-email
    type-bugAn unexpected behavior, bug, or error
    on Jan 2, 2015

  3. serhiy-storchaka commented on Feb 13, 2015

    @serhiy-storchaka
    serhiy-storchaka
    on Feb 13, 2015
    MemberAuthor

    Ping.

  4. bitdancer commented on Feb 21, 2015

    @bitdancer
    bitdancer
    on Feb 21, 2015
    Member

    Same comment as the fold bug...I need to find time to work out a test case (or for someone else to do so).

  5. serhiy-storchaka commented on Jun 19, 2016

    @serhiy-storchaka
    serhiy-storchaka
    on Jun 19, 2016
    MemberAuthor

    The only tests that call cte_encode() are test_address_list_with_unicode_names and test_address_list_with_unicode_names_in_quotes. The only method that calls cte_encode() (besides recursive cte_encode) is TokenList._fold().

    Methods UnstructuredTokenList.cte_encode() and Phrase._fold() are not covered by tests.

  6. python-dev commented on Jul 17, 2016

    @python-dev
    python-devmannequin
    on Jul 17, 2016
    Mannequin

    New changeset efd4ffa88173 by Serhiy Storchaka in branch '3.5':
    Issues bpo-23147, bpo-23148: Presumably fixed bugs in folding UnstructuredTokenList.
    https://hg.python.org/cpython/rev/efd4ffa88173

    New changeset 33593fcdf8b0 by Serhiy Storchaka in branch 'default':
    Issues bpo-23147, bpo-23148: Presumably fixed bugs in folding UnstructuredTokenList.
    https://hg.python.org/cpython/rev/33593fcdf8b0

  7. serhiy-storchaka
    added
    3.7 (EOL)end of life
    on Sep 14, 2016

  8. iritkatriel commented on Dec 13, 2021

    @iritkatriel
    iritkatriel
    on Dec 13, 2021
    Member

    I can't find as_encoded_word anywhere. Even on 3.7 branch.

  9. serhiy-storchaka commented on Dec 14, 2021

    @serhiy-storchaka
    serhiy-storchaka
    on Dec 14, 2021
    MemberAuthor

    The code was completely rewritten in bpo-27240. No tests are needed.

  10. serhiy-storchaka
    closed this as completedon Dec 14, 2021
  11. ezio-melotti
    transferred this issue fromon Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.7 (EOL)end of lifestdlibStandard Library Python modules in the Lib/ directorytopic-emailtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions