Skip to content

marshal needs a lower stack depth for debug builds on Windows #66923

Closed

Description

@zooba
BPO 22734
Nosy @ncoghlan, @pitrou, @giampaolo, @tiran, @zooba
Files
  • marshal.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/zooba'
    closed_at = <Date 2014-11-01.22:16:57.068>
    created_at = <Date 2014-10-26.20:40:05.660>
    labels = ['tests']
    title = 'marshal needs a lower stack depth for debug builds on Windows'
    updated_at = <Date 2014-11-01.22:16:57.067>
    user = 'https://github.com/zooba'

    bugs.python.org fields:

    activity = <Date 2014-11-01.22:16:57.067>
    actor = 'steve.dower'
    assignee = 'steve.dower'
    closed = True
    closed_date = <Date 2014-11-01.22:16:57.068>
    closer = 'steve.dower'
    components = ['Tests']
    creation = <Date 2014-10-26.20:40:05.660>
    creator = 'steve.dower'
    dependencies = []
    files = ['37024']
    hgrepos = []
    issue_num = 22734
    keywords = ['patch']
    message_count = 3.0
    messages = ['230037', '230050', '230466']
    nosy_count = 6.0
    nosy_names = ['ncoghlan', 'pitrou', 'giampaolo.rodola', 'christian.heimes', 'python-dev', 'steve.dower']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue22734'
    versions = ['Python 3.5']

    Activity

    1. zooba commented on Oct 26, 2014

      @zooba
      MemberAuthor

      This patch decreases the stack depth limit for Windows debug builds to prevent the recursion test from failing. (Apparently VC14 uses more stack space for each frame than VC10, but the release build is unaffected.)

      Not sure who the correct nosy for marshal is, so I picked test coverage, as this only really shows up in the tests.

    2. self-assigned this
      on Oct 26, 2014
    3. pitrou commented on Oct 27, 2014

      @pitrou
      Member

      This looks harmless to me.

    4. python-dev commented on Nov 1, 2014

      python-devmannequin
      Mannequin

      New changeset c2a3865a59f4 by Steve Dower in branch 'default':
      bpo-22734 marshal needs a lower stack depth for debug builds on Windows
      https://hg.python.org/cpython/rev/c2a3865a59f4

    5. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    Labels

    testsTests in the Lib/test dir

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions