Skip to content

Get rid of SRE character tables #66774

Closed
Closed

Description

@serhiy-storchaka
BPO 22584
Nosy @pitrou, @ezio-melotti, @serhiy-storchaka
Files
  • sre_tables.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
    closed_at = <Date 2014-10-10.08:45:38.731>
    created_at = <Date 2014-10-09.07:43:50.471>
    labels = ['extension-modules', 'expert-regex', 'type-feature']
    title = 'Get rid of SRE character tables'
    updated_at = <Date 2014-10-10.08:45:38.729>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2014-10-10.08:45:38.729>
    actor = 'serhiy.storchaka'
    assignee = 'serhiy.storchaka'
    closed = True
    closed_date = <Date 2014-10-10.08:45:38.731>
    closer = 'serhiy.storchaka'
    components = ['Extension Modules', 'Regular Expressions']
    creation = <Date 2014-10-09.07:43:50.471>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = ['36841']
    hgrepos = []
    issue_num = 22584
    keywords = ['patch']
    message_count = 3.0
    messages = ['228836', '228965', '228970']
    nosy_count = 5.0
    nosy_names = ['pitrou', 'ezio.melotti', 'mrabarnett', 'python-dev', 'serhiy.storchaka']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue22584'
    versions = ['Python 3.5']

    Activity

    1. serhiy-storchaka commented on Oct 9, 2014

      @serhiy-storchaka
      MemberAuthor

      Currently the SRE regular expression engine uses internal tables to implement ASCII-only character predicates and converting. Proposed patch get rid of these tables and reuse standard Python macros Py_ISSPACE, Py_TOLOWER, etc.

    2. python-dev commented on Oct 10, 2014

      python-devmannequin
      Mannequin

      New changeset 07b7b587837f by Serhiy Storchaka in branch 'default':
      Issue bpo-22584: Got rid of character tables in _sre.c and use standard macros
      https://hg.python.org/cpython/rev/07b7b587837f

    3. serhiy-storchaka commented on Oct 10, 2014

      @serhiy-storchaka
      MemberAuthor

      Thank you for your review Antoine.

    4. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions