Repository navigation
Turn on all tests in test.test_importlib.source.test_file_loader #64998
Description
| BPO | 20799 |
|---|---|
| Nosy | @brettcannon, @matheusportela |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/brettcannon'
closed_at = <Date 2014-03-05.20:24:17.293>
created_at = <Date 2014-02-27.16:46:44.286>
labels = ['easy', 'invalid', 'library']
title = 'Turn on all tests in test.test_importlib.source.test_file_loader'
updated_at = <Date 2014-03-05.20:24:17.292>
user = 'https://github.com/brettcannon'bugs.python.org fields:
activity = <Date 2014-03-05.20:24:17.292>
actor = 'brett.cannon'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2014-03-05.20:24:17.293>
closer = 'brett.cannon'
components = ['Library (Lib)']
creation = <Date 2014-02-27.16:46:44.286>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 20799
keywords = ['easy']
message_count = 3.0
messages = ['212367', '212766', '212768']
nosy_count = 2.0
nosy_names = ['brett.cannon', 'matheus.v.portela']
pr_nums = []
priority = 'normal'
resolution = 'not a bug'
stage = 'needs patch'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue20799'
versions = ['Python 3.5']
Activity
brettcannon commentedon Feb 27, 2014
Some tests have a leading underscore which means they were probably turned off for testing purposes but forgot to be flipped back on. Should turn them back on and make sure that they actually still pass.
matheusportela commentedon Mar 5, 2014
Apparently, the methods with leading underscore are being tested by two classes (SourceLoaderBadBytecodeTest and SourcelessLoaderBadBytecodeTest) that implement methods with similar names (but without the underscore).
Simply removing the underscore breaks the tests since they cannot differ between the methods with and without underscore.
brettcannon commentedon Mar 5, 2014
Thanks for checking, Matheus! Closing this as invalid then.