Repository navigation
expose SSL socket protocol version #64620
Description
| BPO | 20421 |
|---|---|
| Nosy | @pitrou, @giampaolo, @tiran, @benjaminp, @alex, @ethanfurman, @dstufft |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2014-09-04.19:02:06.638>
created_at = <Date 2014-01-28.16:36:54.341>
labels = ['type-feature', 'library']
title = 'expose SSL socket protocol version'
updated_at = <Date 2014-09-04.20:33:36.215>
user = 'https://github.com/pitrou'bugs.python.org fields:
activity = <Date 2014-09-04.20:33:36.215>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2014-09-04.19:02:06.638>
closer = 'pitrou'
components = ['Library (Lib)']
creation = <Date 2014-01-28.16:36:54.341>
creator = 'pitrou'
dependencies = []
files = ['36440', '36509', '36536']
hgrepos = []
issue_num = 20421
keywords = ['patch']
message_count = 14.0
messages = ['209564', '214621', '214864', '216543', '216792', '216793', '225726', '226146', '226370', '226371', '226375', '226376', '226377', '226379']
nosy_count = 10.0
nosy_names = ['geertj', 'janssen', 'pitrou', 'giampaolo.rodola', 'christian.heimes', 'benjamin.peterson', 'alex', 'ethan.furman', 'python-dev', 'dstufft']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue20421'
versions = ['Python 3.5']
Activity
pitrou commentedon Jan 28, 2014
SSL sockets should provide a way to query the current protocol version (e.g. "TLSv1.2"). OpenSSL makes it easy through SSL_get_version().
Open question is whether we return the string returned by SSL_get_version(), or we convert it to one of the constants ssl.PROTOCOL_XXX.
pitrou commentedon Mar 23, 2014
(slightly related: should ssl.PROTOCOL_xxx constants become enum members?)
pitrou commentedon Mar 25, 2014
We could actually use the undocumented "int SSL_version(const SSL *s)" and convert the return value to one of our favourite protocol constants.
ethanfurman commentedon Apr 16, 2014
Sounds good to me.
pitrou commentedon Apr 18, 2014
Ok, it came to me that converting to one of the PROTOCOL* constants can fail in the following case: Python is linked with an OpenSSL that supports a more recent protocol version than the ssl module is aware of. SSL_get_version() can then return a protocol (e.g. "TLSv1.3") that we don't know about, and have no way of converting to an existing constant.
So perhaps we should really simply return the same string as OpenSSL?
giampaolo commentedon Apr 18, 2014
Debatable. Maybe I'm +0.1 for returning the plain string. IMO when it comes to stdlib modules, enums are only really useful for converting integer constants.
pitrou commentedon Aug 23, 2014
Here is a patch. Doc updates still missing.
pitrou commentedon Aug 30, 2014
Updated patch with doc.
python-dev commentedon Sep 4, 2014
New changeset 648685f8d5e9 by Antoine Pitrou in branch 'default':
Issue bpo-20421: Add a .version() method to SSL sockets exposing the actual protocol version in use.
http://hg.python.org/cpython/rev/648685f8d5e9
pitrou commentedon Sep 4, 2014
Pushed to default.
alex commentedon Sep 4, 2014
Should this be backported to 2.7.9?
pitrou commentedon Sep 4, 2014
It's as you want, now. I don't think this is really important, though.
alex commentedon Sep 4, 2014
Attached patch backports it (only change is the use of
closing()and resolving the conflict in Misc/NEWS). I'll leave it up to benjamin whether he wants to commit (input from others welcome). My view is to prefer backporting stuff since it helps keep the diff small.python-dev commentedon Sep 4, 2014
New changeset 16c86a6bdbe2 by Alex Gaynor in branch '2.7':
Issue bpo-20421: Add a .version() method to SSL sockets exposing the actual protocol version in use.
http://hg.python.org/cpython/rev/16c86a6bdbe2