Repository navigation
Derby #16: Convert 50 sites to Argument Clinic across 9 files #64383
Description
| BPO | 20184 |
|---|---|
| Nosy | @ncoghlan, @larryhastings, @serhiy-storchaka, @1st1, @shihai1991 |
| PRs | |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2014-01-08.00:21:44.691>
labels = ['extension-modules', 'type-feature', 'expert-argument-clinic']
title = 'Derby #16: Convert 50 sites to Argument Clinic across 9 files'
updated_at = <Date 2020-10-18.14:54:14.974>
user = 'https://github.com/larryhastings'bugs.python.org fields:
activity = <Date 2020-10-18.14:54:14.974>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Extension Modules', 'Argument Clinic']
creation = <Date 2014-01-08.00:21:44.691>
creator = 'larry'
dependencies = []
files = ['33696', '33701', '33740', '33860', '33861', '34664', '36385', '39032', '39070', '39292']
hgrepos = []
issue_num = 20184
keywords = ['patch']
message_count = 20.0
messages = ['207642', '209159', '209179', '209203', '209409', '209953', '210218', '210375', '215164', '224765', '225385', '225423', '225424', '225425', '241094', '241226', '241347', '242588', '362008', '378872']
nosy_count = 7.0
nosy_names = ['ncoghlan', 'larry', 'nadeem.vawda', 'python-dev', 'serhiy.storchaka', 'yselivanov', 'shihai1991']
pr_nums = ['18512', '22693']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue20184'
versions = ['Python 3.5']
Activity
ncoghlan commentedon Mar 30, 2014
Updated the builtins patch for the 3.4.0 Argument Clinic changes. Also moved the issue back to 3.4, since Larry has indicated that AC conversions are in scope for 3.4.x maintenance releases, so long as no public API behaviour changes.
larryhastings commentedon Aug 4, 2014
All the Derby patches should only go into trunk at this point.
ncoghlan commentedon Aug 16, 2014
Tweaked patch to apply cleanly to trunk, but realised it has been a while since I looked at the current state of argument clinic:
I'm not sure if varargs support has been added yet. If it has, "min", "max", "print", "__build_class__" can be converted. If it hasn't, then the comments referring to 3.4 still need to be updated.
the comments referring to needing groups support in AC aren't quite right, it's optional group support in inspect that's missing. So the comments relating to "range", "slice", "dir", "getattr", "next", "iter", "vars" should be tweaked accordingly
tweaking the behaviour of round to make it AC friendly should probably go into its own issue.
Also, Larry, there's a note in the the 3.4 "What's New" about additional signature info landing in Python 3.4 maintenance releases. That note should probably be adjusted at this point, since any new signature data will only be available in 3.5.
python-dev commentedon Aug 17, 2014
New changeset 6219aa966a5f by Nick Coghlan in branch 'default':
Issue bpo-20184: Add signature introspection for 30 of the builtins
http://hg.python.org/cpython/rev/6219aa966a5f
ncoghlan commentedon Aug 17, 2014
30 of the builtin functions now support signature introspection thanks to Argument Clinic :)
ncoghlan commentedon Aug 17, 2014
(Well, they'll support it in 3.5...)
serhiy-storchaka commentedon Apr 15, 2015
Proposed patch converts _dbm and _gdbm modules to Argument Clinic.
serhiy-storchaka commentedon Apr 16, 2015
The patch updated to the tip.
python-dev commentedon Apr 17, 2015
New changeset 49910ff21ba5 by Serhiy Storchaka in branch 'default':
Issue bpo-20184: Converted _dbm and _gdbm modules to Argument Clinic.
https://hg.python.org/cpython/rev/49910ff21ba5
serhiy-storchaka commentedon May 5, 2015
Here is a patch that converts 3 functions in the _json module to Argument Clinic. All other functions doesn't fit with Argument Clinic.
shihai1991 commentedon Feb 15, 2020
Looks like
builtins.varsandbuiltins.dirshould be migrated to AC too, so I create PR18512.serhiy-storchaka commentedon Oct 18, 2020
New changeset 1bcaa81 by Serhiy Storchaka in branch 'master':
bpo-20184: Convert termios to Argument Clinic. (GH-22693)
1bcaa81
arhadthedev commentedon Feb 13, 2023
Is this metaissue still relevant after nine years? Currently, conversions into AC are handled in smaller, more specific issues so it could be closed.
arhadthedev commentedon Feb 14, 2023
BTW, the derby has a few more parts:
carljm commentedon Feb 20, 2023
It looks to me like all of these derby issues would be better closed. Even if some functions do remain unconverted, it's much more likely at this point that they will be converted because someone notices the unconverted function in the codebase, not because of a derby issue with non-descriptive (and almost certainly now obsolete) name that requires digging through all of the listed modules to see if there's any work remaining to be done on it.
As the derby issues say, it was an effort to convert as much as possible before Python 3.4 release. Python 3.4 is long ago released, so the derby is over.
carljm commentedon Feb 20, 2023
Will leave this open for a bit to see if a core dev agrees before closing all of them.
iritkatriel commentedon Feb 20, 2023
It's been open for long enough now.