Skip to content

Derby: Convert the _tkinter module to use Argument Clinic #64367

Closed
Closed
Derby: Convert the _tkinter module to use Argument Clinic#64367
Assignees
serhiy-storchaka
Labels
extension-modulesC modules in the Modules dirtopic-argument-clinictopic-tkintertype-featureA feature request or enhancement

Description

@serhiy-storchaka
serhiy-storchaka
opened on Jan 7, 2014
BPO 20168
Nosy @larryhastings, @jkloth, @serhiy-storchaka, @zooba
Dependencies
  • bpo-20196: Argument Clinic generates invalid code for optional parameter
    		•
    Files
  • tkinter_clinic.patch
  • tkinter_clinic_2.patch
  • tkinter_clinic_3.patch
  • tkinter_clinic_4.patch
  • larry.fix.tkinter.build.on.windows.diff.1.txt
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2015-05-04.12:47:16.563>
created_at = <Date 2014-01-07.21:03:59.546>
labels = ['extension-modules', 'type-feature', 'expert-tkinter', 'expert-argument-clinic']
title = 'Derby: Convert the _tkinter module to use Argument Clinic'
updated_at = <Date 2015-05-04.12:47:16.562>
user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2015-05-04.12:47:16.562>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2015-05-04.12:47:16.563>
closer = 'serhiy.storchaka'
components = ['Extension Modules', 'Tkinter', 'Argument Clinic']
creation = <Date 2014-01-07.21:03:59.546>
creator = 'serhiy.storchaka'
dependencies = ['20196']
files = ['33528', '34533', '35437', '39091', '39282']
hgrepos = []
issue_num = 20168
keywords = ['patch']
message_count = 18.0
messages = ['207600', '207604', '207605', '207609', '207699', '207706', '207716', '208398', '214259', '219507', '241357', '242471', '242478', '242503', '242507', '242528', '242530', '242533']
nosy_count = 6.0
nosy_names = ['larry', 'jkloth', 'gpolo', 'python-dev', 'serhiy.storchaka', 'steve.dower']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue20168'
versions = ['Python 3.5']

    Activity

    1. serhiy-storchaka commented on Jan 7, 2014

      @serhiy-storchaka
      serhiy-storchaka
      on Jan 7, 2014
      MemberAuthor

      In progress. Actually many functions are not very suitable for Argument Clinic.

    2. serhiy-storchaka
      added
      topic-tkinter
      extension-modulesC modules in the Modules dir
      type-featureA feature request or enhancement
      on Jan 7, 2014
    3. serhiy-storchaka
      self-assigned this
      on Jan 7, 2014

    4. larryhastings commented on Jan 7, 2014

      @larryhastings
      larryhastings
      on Jan 7, 2014
      Contributor

      What functions, and what makes them unsuitable?

    5. serhiy-storchaka commented on Jan 7, 2014

      @serhiy-storchaka
      serhiy-storchaka
      on Jan 7, 2014
      MemberAuthor

      call() just converts all args to Tcl list. Is Argument Clinic supports *args
      and **kwargs? I'm not sure there is a benefit with using Argument Clinic here.

      splitlist() and split() first call PyArg_ParseTuple with one argument, check
      the input, and then may call PyArg_ParseTuple with other argument. They need
      large refactoring to use Argument Clinic.

      getint(), getdouble(), getboolean() first manually unpack arguments tuple, and
      then may call PyArg_ParseTuple. Same as above.

      setvar()/globalsetvar(), getvar()/globalgetvar(), unsetvar()/globalunsetvar()
      shares common code parametrized by flags. I think this is resolvable. But
      worse, they can delegates their execution to other thread and should save all
      arguments in events queue. And this looks absolutely unsuitable for Argument
      Clinic.

    6. larryhastings commented on Jan 7, 2014

      @larryhastings
      larryhastings
      on Jan 7, 2014
      Contributor

      (It would have made it easier on me if you'd used the C function names, instead of the names in the module.)

      I agree. In retrospect, it's not surprising that things in _tkinter aren't suitable, as it appears to be a shunt for calling things in Tcl.

      For what it's worth, Argument Clinic is only intended for functions that use PyArg_ParseTuple or PyArg_ParseTupleOrKeywords to parse their arguments. So something like call is and will forever be unsuitable.

      (And reading _tkinter.c this has reminded me why I don't like Tcl ;-)

    7. larryhastings commented on Jan 8, 2014

      @larryhastings
      larryhastings
      on Jan 8, 2014
      Contributor

      So do you think there are any entry points worth converting in _tkinter, or should we close this issue?

    8. serhiy-storchaka commented on Jan 8, 2014

      @serhiy-storchaka
      serhiy-storchaka
      on Jan 8, 2014
      MemberAuthor

      You misunderstood me. I already have 1018-lines patch which converts about 24
      functions and methods to Argument Clinic church. And I'm working on left
      functions. Do you want to get unfinished patch?

    9. larryhastings commented on Jan 8, 2014

      @larryhastings
      larryhastings
      on Jan 8, 2014
      Contributor

      Oh, okay. That sounds fine, and I'm not in a hurry. Please post the patch whenever you're ready, thanks!

    10. serhiy-storchaka commented on Jan 18, 2014

      @serhiy-storchaka
      serhiy-storchaka
      on Jan 18, 2014
      MemberAuthor

      Here is a patch.

    11. serhiy-storchaka commented on Mar 20, 2014

      @serhiy-storchaka
      serhiy-storchaka
      on Mar 20, 2014
      MemberAuthor

      Here is updated patch.

    12. serhiy-storchaka commented on Jun 1, 2014

      @serhiy-storchaka
      serhiy-storchaka
      on Jun 1, 2014
      MemberAuthor

      Synchronized with tip.

    13. serhiy-storchaka
      added
      topic-argument-clinic
      on Feb 25, 2015

    14. serhiy-storchaka commented on Apr 17, 2015

      @serhiy-storchaka
      serhiy-storchaka
      on Apr 17, 2015
      MemberAuthor

      Updated to the tip. Converted methods getint, getdouble, getboolean, splitlist, split.

    15. python-dev commented on May 3, 2015

      @python-dev
      python-devmannequin
      on May 3, 2015
      Mannequin

      New changeset b22ced894d51 by Serhiy Storchaka in branch 'default':
      Issue bpo-20168: Converted the _tkinter module to Argument Clinic.
      https://hg.python.org/cpython/rev/b22ced894d51

    16. serhiy-storchaka commented on May 3, 2015

      @serhiy-storchaka
      serhiy-storchaka
      on May 3, 2015
      MemberAuthor

      wantobjects() was not converted due to a bug in Argument Clinic (bpo-24051).

    17. serhiy-storchaka
      closed this as completedon May 3, 2015

    18. zooba commented on May 3, 2015

      @zooba
      zooba
      on May 3, 2015
      Member

      This broke Windows builds because of unnecessary "static" qualifiers on the forward declarations at lines 2685 and 3006 (as discussed on bpo-20323).

      Removing "static" from these lines fixes the build.

    19. zooba
      reopened this on May 3, 2015

    20. larryhastings commented on May 3, 2015

      @larryhastings
      larryhastings
      on May 3, 2015
      Contributor

      As mentioned on bpo-20148, removing the "static" from the forward declarations breaks it on GCC. (And, of the two, I think GCC is the one being reasonable here.)

      Attached is a patch that should fix the build for tkinter.

    21. zooba commented on May 3, 2015

      @zooba
      zooba
      on May 3, 2015
      Member

      LGTM

    22. python-dev commented on May 3, 2015

      @python-dev
      python-devmannequin
      on May 3, 2015
      Mannequin

      New changeset 7a76c462c7f6 by Larry Hastings in branch 'default':
      Fix Windows build breakage from checkins on Issues bpo-20148 and bpo-20168.
      https://hg.python.org/cpython/rev/7a76c462c7f6

    23. larryhastings commented on May 3, 2015

      @larryhastings
      larryhastings
      on May 3, 2015
      Contributor

      Steve, please close this issue when you've confirmed it's now building correctly on Windows.

    24. serhiy-storchaka
      closed this as completedon May 4, 2015
    25. ezio-melotti
      transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    Labels

    extension-modulesC modules in the Modules dirtopic-argument-clinictopic-tkintertype-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions