Repository navigation
tracemalloc: rename "max_size" to "peak_size" in get_traced_memory() result #63997
Description
| BPO | 19798 |
|---|---|
| Nosy | @vstinner |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2013-11-27.20:40:11.288>
created_at = <Date 2013-11-26.12:55:01.375>
labels = ['library']
title = 'tracemalloc: rename "max_size" to "peak_size" in get_traced_memory() result'
updated_at = <Date 2013-11-27.20:41:04.602>
user = 'https://github.com/vstinner'bugs.python.org fields:
activity = <Date 2013-11-27.20:41:04.602>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2013-11-27.20:40:11.288>
closer = 'python-dev'
components = ['Library (Lib)']
creation = <Date 2013-11-26.12:55:01.375>
creator = 'vstinner'
dependencies = []
files = ['32856']
hgrepos = []
issue_num = 19798
keywords = ['patch']
message_count = 5.0
messages = ['204470', '204473', '204476', '204610', '204611']
nosy_count = 3.0
nosy_names = ['vstinner', 'neologix', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue19798'
versions = ['Python 3.4']
Activity
vstinner commentedon Nov 26, 2013
Jim.J.Jewett asked me to replaced "max_size" with "peak_size". It looks like Linux also uses the term "peak" for /proc/pid/status (or sometimes "High Water Mark").
See attached patch.
vstinner commentedon Nov 26, 2013
@neologix: I would like your opinion first, because you accepted the PEP.
neologix commentedon Nov 26, 2013
Well, I'm not a native speaker, but "peak" does sound better than
"max" (I'd say the later refers to an externally-enforced limit,
contrarily to the former).
So the change looks fine, although:
"""
`(size: int, peak_size: int)``
"""
Would maybe be better with:
"""
`(current: int, peak: int)``
"""
no?
python-dev commentedon Nov 27, 2013
New changeset 553144bd7bf1 by Victor Stinner in branch 'default':
Close bpo-19798: replace "maximum" term with "peak" in get_traced_memory()
http://hg.python.org/cpython/rev/553144bd7bf1
vstinner commentedon Nov 27, 2013
yes, I also prefer "current" over "size".