Skip to content

selectors and modify() #63696

Closed
Closed
selectors and modify()#63696
Assignees
gvanrossum
Labels
type-featureA feature request or enhancement

Description

@ArnaudFaure
ArnaudFaure
mannequin
opened on Nov 4, 2013
BPO 19497
Nosy @gvanrossum
Files
  • modify_data.patch: Add a shortcut to BaseSelector.modify when update data
  • modify_data.2.patch: patch cpython default branch
  • modify_data.3.patch
  • modify_data_use_a_shortcut.patch: Add a shortcut to BaseSelector.modify when update data
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gvanrossum'
closed_at = <Date 2013-11-07.17:13:54.955>
created_at = <Date 2013-11-04.20:40:21.321>
labels = ['type-feature']
title = 'selectors and modify()'
updated_at = <Date 2013-11-07.17:13:54.954>
user = 'https://bugs.python.org/ArnaudFaure'

    bugs.python.org fields:

    activity = <Date 2013-11-07.17:13:54.954>
actor = 'gvanrossum'
assignee = 'gvanrossum'
closed = True
closed_date = <Date 2013-11-07.17:13:54.955>
closer = 'gvanrossum'
components = []
creation = <Date 2013-11-04.20:40:21.321>
creator = 'Arnaud.Faure'
dependencies = []
files = ['32499', '32503', '32504', '32512']
hgrepos = []
issue_num = 19497
keywords = ['patch']
message_count = 6.0
messages = ['202172', '202176', '202177', '202180', '202249', '202369']
nosy_count = 3.0
nosy_names = ['gvanrossum', 'neologix', 'Arnaud.Faure']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19497'
versions = ['Python 3.4']

    Activity

    1. ArnaudFaure
      added
      type-featureA feature request or enhancement
      on Nov 4, 2013

    2. gvanrossum commented on Nov 4, 2013

      @gvanrossum
      gvanrossum
      on Nov 4, 2013
      Member

      The patch doesn't actually apply, not just because the pathnames are different, but because the unittests in Lib/test/test_selectors.py have a different structure.

    3. ArnaudFaure commented on Nov 4, 2013

      @ArnaudFaure
      ArnaudFauremannequin
      on Nov 4, 2013
      MannequinAuthor

      Didn't thaught about that :( ....
      Did my way throught the developper tutorial, got the default cpython repo, did the modif, run patchcheck then the tests with ./python -m test -j3.
      Thanks for your patience ;)

    4. gvanrossum commented on Nov 4, 2013

      @gvanrossum
      gvanrossum
      on Nov 4, 2013
      Member

      Check out my review: http://bugs.python.org/review/19497/#ps9821

    5. ArnaudFaure commented on Nov 5, 2013

      @ArnaudFaure
      ArnaudFauremannequin
      on Nov 5, 2013
      MannequinAuthor

      patch updated

    6. ArnaudFaure commented on Nov 6, 2013

      @ArnaudFaure
      ArnaudFauremannequin
      on Nov 6, 2013
      MannequinAuthor

      Corrected and cleaned

    7. gvanrossum commented on Nov 7, 2013

      @gvanrossum
      gvanrossum
      on Nov 7, 2013
      Member

      Fixed by revision 9c976f1b17e9.

    8. gvanrossum
      closed this as completedon Nov 7, 2013
    9. gvanrossum
      self-assigned this
      on Nov 7, 2013
    10. ezio-melotti
      transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    Labels

    type-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions