Repository navigation
README.valgrind should mention --with-valgrind #63059
Description
| BPO | 18859 |
|---|---|
| Nosy | @tim-one, @ambv, @elenaoat, @CuriousLearner |
| PRs | |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/ambv'
closed_at = <Date 2018-11-20.11:12:05.530>
created_at = <Date 2013-08-28.00:19:48.855>
labels = ['easy', 'type-feature', '3.8', 'build']
title = 'README.valgrind should mention --with-valgrind'
updated_at = <Date 2018-11-20.11:12:05.518>
user = 'https://github.com/tim-one'bugs.python.org fields:
activity = <Date 2018-11-20.11:12:05.518>
actor = 'lukasz.langa'
assignee = 'lukasz.langa'
closed = True
closed_date = <Date 2018-11-20.11:12:05.530>
closer = 'lukasz.langa'
components = ['Build']
creation = <Date 2013-08-28.00:19:48.855>
creator = 'tim.peters'
dependencies = []
files = ['36209', '42147']
hgrepos = []
issue_num = 18859
keywords = ['patch', 'easy']
message_count = 9.0
messages = ['196338', '196548', '224559', '224573', '261647', '294386', '330109', '330125', '330126']
nosy_count = 7.0
nosy_names = ['tim.peters', 'mmokrejs', 'lukasz.langa', 'Elena.Oat', 'sowmya-ravidas', 'CuriousLearner', 'Sourav Singh']
pr_nums = ['10591']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue18859'
versions = ['Python 3.8']
Activity
tim-one commentedon Aug 28, 2013
In bpo-18843 a user noted that Misc/README.valgrind doesn't mention the --with-valgrind configure option. It probably should. But since I've never used valgrind, I'm not the guy to do it ;-)
mmokrejs commentedon Aug 30, 2013
Moreover, it should explain what that really does. One could think of several answers or even their combinations what this configure flag will really do:
a) python will run itself under valgrind, don't bother ever doing it yourself
b) you don't have to bother with uncommenting the lines in valgrind.supp
c) "make install" will install the valgrind.supp but you have to edit it on your own
d) you may use valgrind but don't use other tool replacing malloc(), like electric fence, DUMA, etc. You should be quite verbose how (in)compatible is this with other tools.
Or some combination of them?
valgrind docs say it won't work if a binary lacks debug symbols (wasn't compiled with -g). Initially I got mislead I though I have to convert my blah.py to blah.c using cython, compile that with "gcc -ggdb blah.c" and then I may run valgrind on the binary.
In the end, I don't understand why everybody has to remove the comment symbols from the valgrind-python.supp file at all. Why isn't that by default enabled?
I also suggest you mention right in the file other handy information because people quite likely get on this path while chasing memory corruption issues, maybe broken hardware:
Thank you!
sowmya-ravidas commentedon Aug 2, 2014
Hi,
I have created a patch for this bug.
The Misc/README.valgrind now mentions the --with-valgrind configure options.
skrah commentedon Aug 2, 2014
Hi Sowmya. Currently we have the option to use --with-valgrind or
the old method --without-pymalloc. Both methods work.
elenaoat commentedon Mar 12, 2016
I've combined the patch submitted by Sowmya and also added there clarifications from points 1, 2 mentioned by Martin Mokrejs.
SouravSingh commentedon May 24, 2017
Is the issue fixed?
CuriousLearner commentedon Nov 19, 2018
Patch added in PR: #10591
ambv commentedon Nov 20, 2018
New changeset d5d3368 by Łukasz Langa (Sanyam Khurana) in branch 'master':
bpo-18859: Document --with-valgrind option in README.valgrind (bpo-10591)
d5d3368
ambv commentedon Nov 20, 2018
Thanks! ✨ 🍰 ✨