Repository navigation
buttons in turtledemo disappear on small screens #62332
Description
| BPO | 18132 |
|---|---|
| Nosy | @terryjreedy |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2014-07-23.19:04:42.652>
created_at = <Date 2013-06-04.13:46:45.135>
labels = ['type-bug']
title = 'buttons in turtledemo disappear on small screens'
updated_at = <Date 2014-07-23.19:04:42.650>
user = 'https://bugs.python.org/JanKanis'bugs.python.org fields:
activity = <Date 2014-07-23.19:04:42.650>
actor = 'terry.reedy'
assignee = 'none'
closed = True
closed_date = <Date 2014-07-23.19:04:42.652>
closer = 'terry.reedy'
components = ['Demos and Tools']
creation = <Date 2013-06-04.13:46:45.135>
creator = 'JanKanis'
dependencies = []
files = ['30469']
hgrepos = ['195']
issue_num = 18132
keywords = ['patch']
message_count = 7.0
messages = ['190596', '190652', '219295', '219490', '219713', '219719', '223762']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'JanKanis']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue18132'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']
Activity
JanKanis commentedon Jun 4, 2013
If the window of the turtledemo is small enough, the start/stop/clear buttons disappear. This is specifically a problem when running on a netbook with a small screen, because the buttons are never shown. For a newcommer checking out the demo app this could be very confusing as there is no indication on what went wrong, and the notification area just says 'press start button'.
JanKanis commentedon Jun 5, 2013
I've created a patch, replacing the packed layout by a gridded layout
terryjreedy commentedon May 28, 2014
On my widescreen, the buttons are completely gone when I shrink vertically to about 720 pixels. So they must be gone on a 600x800 screen or 720x1280 small widescreen and perhaps on a non-fullscreen window on a 780x10xx screen. I agree with fixing this if possible.
The patch applies cleanly to 3.4 and fixes the problem with the buttons. However, it introduces a problem with the vertical canvas scrollbar, on the right. It does not appear when it should and does not scroll the entire canvas when it does appear. Try it with bytedesign, and see if you can fix it with an altered patch.
terryjreedy commentedon Jun 1, 2014
I believe I have read more than one warning to not mix grid and pack in the same master, as your patch does. For example: http://effbot.org/tkinterbook/grid.htm, An option would be to grid everything. I believe grid would also fix issue bpo-21597, so I may try it and see if it fixes both issue without introducing a scrollbar problem.
JanKanis commentedon Jun 3, 2014
I wasn't aware that mixing grid and pack was a bad idea, as I was looking over turtledemo to learn how to use tkinter. The patch replaces a packing in one frame with a grid. All direct children of the graph_frame are gridded. graph_frame itself is still packed and so are the children of btn_frame which is a child of graph_frame.
Also I wasn't able to find a clear definition of what is meant by 'master window' in the grid/pack warning, but supposedly that is the top level Tk() rather than a parent widget. I would offer to create a better patch but Lita Cho already did so in bpo-21597.
terryjreedy commentedon Jun 3, 2014
I had forgotten until I reread Lundh's note. I made the same assumption about 'master window'. Certainly 'conservative' is safest. Lita has not posted a patch, but since she is a (paid) summer intern (until mid August), I expect she will. If not, you can help finish this off before the next release cycle, which should be at least 3 months away. If you notice that nothing has happened by mid-August, please ping either or both issues.
terryjreedy commentedon Jul 23, 2014
Fixed by
New changeset 60301b9982b2 by Terry Jan Reedy in branch '2.7':
Issue bpo-21597: Turtledemo text pane can now be widened to view or copy complete
http://hg.python.org/cpython/rev/60301b9982b2
New changeset 0fb515063324 by Terry Jan Reedy in branch '3.4':
Issue bpo-21597: Turtledemo text pane can now be widened to view or copy complete
http://hg.python.org/cpython/rev/0fb515063324