Repository navigation
idlelib.configSectionNameDialog: fix and add tests and mocks #62330
Description
| BPO | 18130 |
|---|---|
| Nosy | @terryjreedy |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2013-06-05.22:57:32.710>
created_at = <Date 2013-06-04.00:15:19.792>
labels = ['expert-IDLE', 'type-bug']
title = 'idlelib.configSectionNameDialog: fix and add tests and mocks'
updated_at = <Date 2013-06-05.22:57:32.709>
user = 'https://github.com/terryjreedy'bugs.python.org fields:
activity = <Date 2013-06-05.22:57:32.709>
actor = 'terry.reedy'
assignee = 'none'
closed = True
closed_date = <Date 2013-06-05.22:57:32.710>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2013-06-04.00:15:19.792>
creator = 'terry.reedy'
dependencies = []
files = ['30459', '30460']
hgrepos = []
issue_num = 18130
keywords = ['patch']
message_count = 2.0
messages = ['190572', '190686']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue18130'
versions = ['Python 2.7', 'Python 3.3', 'Python 3.4']
Activity
terryjreedy commentedon Jun 4, 2013
The patch to configSectionNameDialog.py fixes the human test (adds required arg) so it runs, adds instructions to the test, fixes a bug in name_ok, removes redundant code, adds needed spaces, de-camelcases internal names, and changes the master for the two StringVars so they can be collected [sys:1: ResourceWarning: gc: 2 uncollectable objects at shutdown [<tkinter.StringVar object at 0x02C597E0>, <tkinter.StringVar ...]]. (I plan to open an issue about this.)
The new mock_tk.py adds generic mocks for tkinter String/Int/BooleanVars and tkinter.messagebox and its 8 functions. The new test_name_dialog.py uses these to unittest the non-gui parts of the dialog.
The backport to 2.7 required changes to the tkinter imports and print in configSectionNameDialog.py and in test_config_name.py, addition of '.im_func' to the names of methods/functions being added to the dummy class.
Both unittests and human tests run on all three branches. I believe the patches are ready to commit.
python-dev commentedon Jun 5, 2013
New changeset db4ecaf852e3 by Terry Jan Reedy in branch '3.3':
bpo-18130: Test class idlelib.configSectionNameDialog.GetCfgSectionNameDialog.
http://hg.python.org/cpython/rev/db4ecaf852e3
New changeset 31a67a0194ec by Terry Jan Reedy in branch '2.7':
bpo-18130: Test class idlelib.configSectionNameDialog.GetCfgSectionNameDialog.
http://hg.python.org/cpython/rev/31a67a0194ec
New changeset 382f4718e765 by Terry Jan Reedy in branch '3.3':
bpo-18130: delete extra spaces
http://hg.python.org/cpython/rev/382f4718e765