HTTPConnection.send #61775

Activity

1. dspublicfreemailhu commented on Mar 29, 2013

   

   dspublicfreemailhumannequin

   on Mar 29, 2013

   MannequinAuthor

   More actions

   http.client modul, HTTPConnection object, send method

   Missing an "else" for self.sock.sendall(data) try block.

   ...
   if hasattr(data, "read") :
   if self.debuglevel > 0:
   print("sendIng a read()able")
   encode = False
   try:
   mode = data.mode
   except AttributeError:
   # io.BytesIO and other file-like objects don't have a mode
   # attribute.
   pass
   else:
   if "b" not in mode:
   encode = True
   if self.debuglevel > 0:
   print("encoding file using iso-8859-1")
   while 1:
   datablock = data.read(blocksize)
   if not datablock:
   break
   if encode:
   datablock = datablock.encode("iso-8859-1")
   self.sock.sendall(datablock)
   else: #missing else
   try:
   self.sock.sendall(data)
   except TypeError:
   if isinstance(data, collections.Iterable):
   for d in data:
   self.sock.sendall(d)
   else:
   raise TypeError("data should be a bytes-like object "
   "or an iterable, got %r" % type(data))
2. dspublicfreemailhu

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Mar 29, 2013
3. StephenTu commented on Apr 13, 2013

   

   StephenTumannequin

   on Apr 13, 2013

   Mannequin

   More actions

   I don't think this is a bug anymore in the codebase- looking at Lib/http/client.py, if hasattr(data, "read") is true, then the branch will return unconditionally.

           if hasattr(data, "read") :
               if self.debuglevel > 0: 
                   print("sendIng a read()able")
               encode = False
               try: 
                   mode = data.mode
               except AttributeError:
                   # io.BytesIO and other file-like objects don't have a `mode`
                   # attribute.
                   pass 
               else:
                   if "b" not in mode:
                       encode = True 
                       if self.debuglevel > 0: 
                           print("encoding file using iso-8859-1")
               while 1:
                   datablock = data.read(blocksize)
                   if not datablock:
                       break
                   if encode:
                       datablock = datablock.encode("iso-8859-1")
                   self.sock.sendall(datablock)
               return
4. dspublicfreemailhu commented on Apr 14, 2013

   

   dspublicfreemailhumannequin

   on Apr 14, 2013

   MannequinAuthor

   More actions

   Thank you Stephen.Tu for information. I think so, the "return" has been found ;-)
5. dspublicfreemailhu

   closed this as completedon Apr 14, 2013
6. ezio-melotti

   transferred this issue fromon Apr 10, 2022