Skip to content

backport of the _sysconfigdata.py module (issue 13150) breaks the build on darwin #61714

Closed

Description

@doko42
BPO 17512
Nosy @Yhg1s, @doko42, @ronaldoussoren, @pitrou, @benjaminp, @ned-deily
Files
  • workaround.diff
  • backport.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/doko42'
    closed_at = <Date 2016-09-12.02:50:49.815>
    created_at = <Date 2013-03-21.22:56:23.527>
    labels = ['build']
    title = 'backport of the _sysconfigdata.py module (issue 13150) breaks the build on darwin'
    updated_at = <Date 2016-09-12.02:50:49.814>
    user = 'https://github.com/doko42'

    bugs.python.org fields:

    activity = <Date 2016-09-12.02:50:49.814>
    actor = 'berker.peksag'
    assignee = 'doko'
    closed = True
    closed_date = <Date 2016-09-12.02:50:49.815>
    closer = 'berker.peksag'
    components = ['Build']
    creation = <Date 2013-03-21.22:56:23.527>
    creator = 'doko'
    dependencies = []
    files = ['29537', '29543']
    hgrepos = []
    issue_num = 17512
    keywords = ['patch']
    message_count = 10.0
    messages = ['184919', '184923', '184928', '184944', '184945', '184946', '184970', '185063', '185072', '186331']
    nosy_count = 7.0
    nosy_names = ['twouters', 'doko', 'ronaldoussoren', 'pitrou', 'benjamin.peterson', 'ned.deily', 'python-dev']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue17512'
    versions = ['Python 2.7']

    Activity

    1. doko42 commented on Mar 21, 2013

      @doko42
      MemberAuthor

      The backport of bpo-13150 to the 2.7 branch breaks the build on darwin. There is a special case for providing the _sysconfigdata module in _generate_posix_vars before get_platform is called (darwin only) and before the module is actually written.

      However get_platform is called before, in site.addbuilddir(). Wondering if this call can either be avoided, or worked around.

      options:

      any other options?

    2. self-assigned this
      on Mar 21, 2013
    3. added
      buildThe build process and cross-build
      on Mar 21, 2013
    4. doko42 commented on Mar 21, 2013

      @doko42
      MemberAuthor

      untested work-around. we don't need the builddir to generate the _sysconfigdata.py.

    5. benjaminp commented on Mar 22, 2013

      @benjaminp
      Contributor

      Backporting 4742e7aea2f5 would seem to be the simplest and most "correct" solution.

    6. doko42 commented on Mar 22, 2013

      @doko42
      MemberAuthor

      here's the backport, tested on Linux only. sorry, can't test this on MacOSX before Sunday.

    7. ronaldoussoren commented on Mar 22, 2013

      @ronaldoussoren
      Contributor

      Reverting the backport would also fix the breakage.

      Is the addition of _sysconfigdata not a new feature? It changes the place where sysconfig (and distutils sysconfig?) looks for configuration data, and hence breaks all instructions that mention that you can change the Makefile in {sys.prefix}/lib/python2.7/config to globally affect the compilation flags (although there hopefully aren't a lot of those)

    8. ronaldoussoren commented on Mar 22, 2013

      @ronaldoussoren
      Contributor

      Guess what, I hadn't read the thread on this python-dev yet :-(

    9. benjaminp commented on Mar 22, 2013

      @benjaminp
      Contributor

      I backed it out until it can be done without breaking OSX. d174cb3f5b9e

    10. benjaminp commented on Mar 23, 2013

      @benjaminp
      Contributor

      Can landed corrected in 2.7.5.

    11. doko42 commented on Mar 23, 2013

      @doko42
      MemberAuthor

      tested the backport on MacOSX, fixing the build.

    12. python-dev commented on Apr 8, 2013

      python-devmannequin
      Mannequin

      New changeset be3b4aa2ad28 by doko in branch '2.7':

    13. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    Labels

    buildThe build process and cross-build

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions