Skip to content

Deleting Request data does not update Content-length header. #61687

Closed

Description

@dwoz
mannequin
BPO 17485
Nosy @orsenthil, @bitdancer
Files
  • patch.diff: Patch to resolve and test this issue
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2013-03-20.04:17:49.603>
    created_at = <Date 2013-03-19.20:25:50.901>
    labels = ['type-bug', 'library']
    title = 'Deleting Request data does not update Content-length header.'
    updated_at = <Date 2014-03-10.22:11:19.380>
    user = 'https://bugs.python.org/dwoz'

    bugs.python.org fields:

    activity = <Date 2014-03-10.22:11:19.380>
    actor = 'python-dev'
    assignee = 'none'
    closed = True
    closed_date = <Date 2013-03-20.04:17:49.603>
    closer = 'r.david.murray'
    components = ['Library (Lib)']
    creation = <Date 2013-03-19.20:25:50.901>
    creator = 'dwoz'
    dependencies = []
    files = ['29485']
    hgrepos = []
    issue_num = 17485
    keywords = ['patch']
    message_count = 4.0
    messages = ['184668', '184731', '184734', '213094']
    nosy_count = 4.0
    nosy_names = ['orsenthil', 'r.david.murray', 'python-dev', 'dwoz']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue17485'
    versions = ['Python 3.4']

    Activity

    1. dwoz commented on Mar 19, 2013

      dwozmannequin
      MannequinAuthor

      The patch to fix issue http://bugs.python.org/issue16464 neglects the deleter method of the Request.data property. This allows Request._data to get updated without removing the Content-length header.

    2. added
      stdlibStandard Library Python modules in the Lib/ directory
      on Mar 19, 2013
    3. python-dev commented on Mar 20, 2013

      python-devmannequin
      Mannequin

      New changeset b1579eb4e1bc by R David Murray in branch 'default':
      bpo-17485: Delete the Content-Length header if the data attribute is deleted.
      http://hg.python.org/cpython/rev/b1579eb4e1bc

    4. bitdancer commented on Mar 20, 2013

      @bitdancer
      Member

      Thanks, Daniel. I moved the test so that it would be run even if the network resource is not enabled.

    5. python-dev commented on Mar 10, 2014

      python-devmannequin
      Mannequin

      New changeset e6d862886e5c by R David Murray in branch 'default':
      whatsnew: urllib Request objects are now reusable.
      http://hg.python.org/cpython/rev/e6d862886e5c

    6. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      stdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions