Skip to content

PEP 3121, 384 Refactoring applied to posix module #59896

Closed
Closed
PEP 3121, 384 Refactoring applied to posix module#59896
Labels
extension-modulesC modules in the Modules dirperformancePerformance or resource usage

Description

@RobinSchreiber
RobinSchreiber
mannequin
opened on Aug 16, 2012
BPO 15691
Nosy @vstinner
Files
  • posix_pep3121-384_v0.patch
  • posix_pep3121-384_v1.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2020-06-22.09:23:50.851>
created_at = <Date 2012-08-16.09:48:04.963>
labels = ['extension-modules', 'performance']
title = 'PEP 3121, 384 Refactoring applied to posix module'
updated_at = <Date 2020-06-22.09:23:50.850>
user = 'https://bugs.python.org/RobinSchreiber'

    bugs.python.org fields:

    activity = <Date 2020-06-22.09:23:50.850>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2020-06-22.09:23:50.851>
closer = 'vstinner'
components = ['Extension Modules']
creation = <Date 2012-08-16.09:48:04.963>
creator = 'Robin.Schreiber'
dependencies = []
files = ['26852', '28317']
hgrepos = []
issue_num = 15691
keywords = ['patch', 'pep3121']
message_count = 3.0
messages = ['168367', '177493', '372063']
nosy_count = 2.0
nosy_names = ['vstinner', 'Robin.Schreiber']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue15691'
versions = ['Python 3.4']

    Activity

    1. RobinSchreiber commented on Aug 16, 2012

      @RobinSchreiber
      RobinSchreibermannequin
      on Aug 16, 2012
      MannequinAuthor

      Changes proposed in PEP-3121 and PEP-384 have now been applied to the posix module!

    2. RobinSchreiber
      added
      extension-modulesC modules in the Modules dir
      performancePerformance or resource usage
      on Aug 16, 2012

    3. RobinSchreiber commented on Dec 14, 2012

      @RobinSchreiber
      RobinSchreibermannequin
      on Dec 14, 2012
      MannequinAuthor

      Updated posixmodule to work with the 3.4 Branch version.

    4. vstinner commented on Jun 22, 2020

      @vstinner
      vstinner
      on Jun 22, 2020
      Member

      Fixed by:

      commit 1c2fa78
      Author: Victor Stinner <vstinner@python.org>
      Date: Sun May 10 11:05:29 2020 +0200

      bpo-40549: Convert posixmodule.c to multiphase init (GH-19982)

Convert posixmodule.c ("posix" or "nt" module) to the multiphase
initialization (PEP-489).

* Create the module using PyModuleDef_Init().
* Create ScandirIteratorType and DirEntryType with the new
  PyType_FromModuleAndSpec() (PEP-573)
* Get the module state from ScandirIteratorType and DirEntryType with
  the new PyType_GetModule() (PEP-573)
* Pass module to functions which access the module state.
* convert_sched_param() gets a new module parameter. It is now called
  directly since Argument Clinic doesn't support passing the module
  to an argument converter callback.
* Remove _posixstate_global macro.
    5. vstinner
      closed this as completedon Jun 22, 2020
    6. ezio-melotti
      transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      extension-modulesC modules in the Modules dirperformancePerformance or resource usage

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions