Skip to content

PEP 3121 refactoring applied to audioop module #59885

Closed

Description

@RobinSchreiber
BPO 15680
Nosy @loewis, @vstinner
Superseder
  • bpo-1635741: Py_Finalize() doesn't clear all Python objects at exit
  • Files
  • audioop_pep3121_v0.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2020-09-07.13:48:02.457>
    created_at = <Date 2012-08-16.08:21:54.213>
    labels = ['extension-modules', 'performance']
    title = 'PEP 3121 refactoring applied to audioop module'
    updated_at = <Date 2020-09-07.13:48:02.455>
    user = 'https://bugs.python.org/RobinSchreiber'

    bugs.python.org fields:

    activity = <Date 2020-09-07.13:48:02.455>
    actor = 'vstinner'
    assignee = 'none'
    closed = True
    closed_date = <Date 2020-09-07.13:48:02.457>
    closer = 'vstinner'
    components = ['Extension Modules']
    creation = <Date 2012-08-16.08:21:54.213>
    creator = 'Robin.Schreiber'
    dependencies = []
    files = ['26842']
    hgrepos = []
    issue_num = 15680
    keywords = ['patch', 'pep3121']
    message_count = 3.0
    messages = ['168353', '220645', '376483']
    nosy_count = 3.0
    nosy_names = ['loewis', 'vstinner', 'Robin.Schreiber']
    pr_nums = []
    priority = 'normal'
    resolution = 'duplicate'
    stage = 'resolved'
    status = 'closed'
    superseder = '1635741'
    type = 'resource usage'
    url = 'https://bugs.python.org/issue15680'
    versions = ['Python 3.4']

    Activity

    1. RobinSchreiber commented on Aug 16, 2012

      RobinSchreibermannequin
      MannequinAuthor

      Changes proposed in PEP-3121 have now been applied to the audioop module!

    2. BreamoreBoy commented on Jun 15, 2014

      BreamoreBoymannequin
      Mannequin

      Could somebody review the attached patch please.

    3. vstinner commented on Sep 7, 2020

      @vstinner
      Member

      Fixed by:

      commit 41fbf86
      Author: Hai Shi <shihai1992@gmail.com>
      Date: Thu Mar 12 00:49:11 2020 +0800

      bpo-1635741: Port audioop extension module to multiphase initialization (PEP-489) (GH-18608)
      
      Co-authored-by: Victor Stinner <vstinner@python.org>
      
    4. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      extension-modulesC modules in the Modules dirperformancePerformance or resource usage

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions