Repository navigation
Implement imp.get_tag() using sys.implementation #59371
Description
| BPO | 15166 |
|---|---|
| Nosy | @brettcannon, @birkenfeld, @merwok, @ericsnowcurrently |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2012-07-02.19:15:47.772>
created_at = <Date 2012-06-24.19:50:12.189>
labels = ['easy', 'library', 'release-blocker']
title = 'Implement imp.get_tag() using sys.implementation'
updated_at = <Date 2012-07-03.06:54:38.499>
user = 'https://github.com/brettcannon'bugs.python.org fields:
activity = <Date 2012-07-03.06:54:38.499>
actor = 'eric.snow'
assignee = 'none'
closed = True
closed_date = <Date 2012-07-02.19:15:47.772>
closer = 'brett.cannon'
components = ['Library (Lib)']
creation = <Date 2012-06-24.19:50:12.189>
creator = 'brett.cannon'
dependencies = []
files = ['26170']
hgrepos = []
issue_num = 15166
keywords = ['patch', 'easy']
message_count = 10.0
messages = ['163829', '164094', '164105', '164528', '164529', '164530', '164552', '164559', '164561', '164583']
nosy_count = 6.0
nosy_names = ['brett.cannon', 'georg.brandl', 'eric.araujo', 'python-dev', 'eric.snow', 'jeffknupp']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue15166'
versions = ['Python 3.3']
Activity
brettcannon commentedon Jun 24, 2012
Title says it all. This also implies updating importlib to use sys.implementation directly.
jeffknupp commentedon Jun 26, 2012
Adding patch. If I misunderstood the issue, let me know.
birkenfeld commentedon Jun 26, 2012
Moving to blocker for beta2.
python-dev commentedon Jul 2, 2012
New changeset b36bed82c9d0 by Brett Cannon in branch 'default':
Issue bpo-15166: Re-implement imp.get_tag() using sys.implementation.
http://hg.python.org/cpython/rev/b36bed82c9d0
brettcannon commentedon Jul 2, 2012
I ended up applying Eric's patch from bpo-14797 and then comparing against Jeff's patch here since Eric's cleaned up the C code. Thanks to both for the work!
brettcannon commentedon Jul 2, 2012
I meant issue bpo-13959 for Eric's patch; wrong tab. =)
merwok commentedon Jul 2, 2012
One small thing: this comment from import.c was not copied to sysmodule.c and is now deleted:
ericsnowcurrently commentedon Jul 2, 2012
Good catch. However, do we need that comment? The tag is programmatically derived from the version (in Python/sysmodule.c).
merwok commentedon Jul 2, 2012
Ah, good, if it’s automatically derived then we don’t need the comment.
ericsnowcurrently commentedon Jul 3, 2012
There was some concern with PyImport_GetMagicTag() extracting its value from sys.implementation.cache_tag. I've addressed this in bpo-15242.