Repository navigation
2to3 fix_renames doesn't rename string.lowercase/uppercase/letters #57481
Description
| BPO | 13272 |
|---|---|
| Nosy | @benjaminp, @ezio-melotti, @meadori, @aldwinaldwin |
| PRs | |
| Superseder | |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2021-10-20.22:58:48.728>
created_at = <Date 2011-10-27.07:27:05.298>
labels = ['easy', 'type-bug', 'expert-2to3']
title = "2to3 fix_renames doesn't rename string.lowercase/uppercase/letters"
updated_at = <Date 2021-10-20.22:58:48.728>
user = 'https://github.com/ezio-melotti'bugs.python.org fields:
activity = <Date 2021-10-20.22:58:48.728>
actor = 'iritkatriel'
assignee = 'none'
closed = True
closed_date = <Date 2021-10-20.22:58:48.728>
closer = 'iritkatriel'
components = ['2to3 (2.x to 3.x conversion tool)']
creation = <Date 2011-10-27.07:27:05.298>
creator = 'ezio.melotti'
dependencies = []
files = ['36586']
hgrepos = []
issue_num = 13272
keywords = ['patch', 'easy']
message_count = 5.0
messages = ['146475', '221808', '226659', '226660', '348107']
nosy_count = 6.0
nosy_names = ['benjamin.peterson', 'ezio.melotti', 'meador.inge', 'Anthony.Kong', 'superluser', 'aldwinaldwin']
pr_nums = ['14835']
priority = 'normal'
resolution = 'wont fix'
stage = 'resolved'
status = 'closed'
superseder = '45544'
type = 'behavior'
url = 'https://bugs.python.org/issue13272'
versions = ['Python 2.7', 'Python 3.4', 'Python 3.5']
Activity
ezio-melotti commentedon Oct 27, 2011
They should be renamed to ascii_*.
BreamoreBoy commentedon Jun 28, 2014
@ezio can you prepare a patch for this?
superluser commentedon Sep 9, 2014
Changing the imports only is straightforward, but I'm having trouble detecting and changing future uses of the variables, without also clobbering user-defined variables with the same names.
I notice some of the current fixers have similar problems, for example the itertools fixer changes:
to
This patch is a little smarter than that, but it only detects top-level definitions. For example, the lowercase in
still gets renamed.
I can work on this more, but would like to know:
a) whether this fix is still wanted
b) how smart it needs to be
c) whether my approach is reasonable. I feel like there should be an easier way.
superluser commentedon Sep 9, 2014
...
d) how to format code :\
aldwinaldwin commentedon Jul 18, 2019
there were many small issues with the patch, improved as good as possible the FixString to catch
import as,from string import *andimport stringdid not include the FixStringImports as it's not a necessity to work in Python3
indeed, some uses of the constant names that are user-defined will also rename, only when it's in a
import string. Added aCautionin the documentation. Still, when all are changed, it should not affect the Python3 version, will just work with the renamed variable name.