Repository navigation
Remove duplicate definition of write_record_file #57407
Description
| BPO | 13198 |
|---|---|
| Nosy | @vsajip, @tarekziade, @merwok, @asvetlov |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/merwok'
closed_at = <Date 2014-03-12.09:41:37.139>
created_at = <Date 2011-10-17.13:12:33.949>
labels = ['easy']
title = 'Remove duplicate definition of write_record_file'
updated_at = <Date 2014-03-12.09:41:37.138>
user = 'https://github.com/merwok'bugs.python.org fields:
activity = <Date 2014-03-12.09:41:37.138>
actor = 'eric.araujo'
assignee = 'eric.araujo'
closed = True
closed_date = <Date 2014-03-12.09:41:37.139>
closer = 'eric.araujo'
components = ['Distutils2']
creation = <Date 2011-10-17.13:12:33.949>
creator = 'eric.araujo'
dependencies = []
files = ['24494']
hgrepos = []
issue_num = 13198
keywords = ['patch', 'easy', 'needs review']
message_count = 13.0
messages = ['145687', '147508', '153012', '153077', '153104', '153186', '153214', '153340', '153363', '178248', '179342', '179542', '213231']
nosy_count = 5.0
nosy_names = ['vinay.sajip', 'tarek', 'eric.araujo', 'asvetlov', 'alexis']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue13198'
versions = ['3rd party']
Activity
merwok commentedon Oct 17, 2011
We have duplicate code to write a PEP-376 RECORD file in packaging.util and packaging.command.install_distinfo. The command should use the function from p7g.util. Tests would also be good: Currently, one function uses LF as end of line (change made by Tarek, so authoritative) but the other uses os.linesep.
merwok commentedon Nov 12, 2011
Here’s the patch produced by Mike and I so far.
merwok commentedon Feb 10, 2012
Mike, if you don’t have the time to finish this shortly, I will do it, as I need this fixed for another bug. Just let me know if you’d like to do it.
mikehoy commentedon Feb 10, 2012
I am unable to work on this issue at this time.
On Thu, Feb 9, 2012 at 8:57 PM, Éric Araujo <report@bugs.python.org> wrote:
merwok commentedon Feb 11, 2012
OK. Thanks for your help!
merwok commentedon Feb 12, 2012
Patch attached. Adding people from bpo-13175 for review/testing on Windows.
pfmoore commentedon Feb 12, 2012
Produces RECORD files with CR-CR-LF line endings (see bpo-13175). This breaks pysetup remove.
I can't tell if this patch is good otherwise - it's certainly no worse than the behaviour of the unpatched version, but that's not saying much :-)
merwok commentedon Feb 14, 2012
Damn, bitten by the use of universal newlines! I guess I should split on a literal '\n' instead of calling splitlines. Could you make that change in your clone and tell me if it does the trick?
pfmoore commentedon Feb 14, 2012
Not for a few days, but I'll check when I'm back home
asvetlov commentedon Dec 26, 2012
Close as out of date. Packaging has been removed from stdlib.
merwok commentedon Jan 8, 2013
Please don’t; distutils2 still exists and is mutating into one or more projects where these bug reports will be useful. If it bothers Python core devs to have the bugs in this tracker, they will be migrated, but for the moment please leave them open so they can be found.
asvetlov commentedon Jan 10, 2013
Eric, if you want to keep distutils2 issues on the tracker for a while — I'm ok with that.
merwok commentedon Mar 12, 2014
wheel/distlib/pip don’t have the same code, and if they had the same issue it would probably be found by a user. Closing.