Repository navigation
"Print window" menu on IDLE aborts whole application #56483
Description
| BPO | 12274 |
|---|---|
| Nosy | @terryjreedy, @kbkaiser, @ambv |
| Dependencies |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2016-10-05.10:26:41.982>
created_at = <Date 2011-06-07.06:16:07.104>
labels = ['expert-IDLE', 'type-bug']
title = '"Print window" menu on IDLE aborts whole application'
updated_at = <Date 2016-10-05.10:26:41.981>
user = 'https://bugs.python.org/ggenellina'bugs.python.org fields:
activity = <Date 2016-10-05.10:26:41.981>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2016-10-05.10:26:41.982>
closer = 'berker.peksag'
components = ['IDLE']
creation = <Date 2011-06-07.06:16:07.104>
creator = 'ggenellina'
dependencies = ['15392']
files = []
hgrepos = []
issue_num = 12274
keywords = []
message_count = 7.0
messages = ['137789', '137790', '137823', '137825', '220036', '220054', '228257']
nosy_count = 6.0
nosy_names = ['terry.reedy', 'kbk', 'ggenellina', 'BreamoreBoy', 'lukasz.langa', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue12274'
versions = ['Python 3.2', 'Python 3.3']
Activity
ggenellina commentedon Jun 7, 2011
On Windows, IDLE closes all open windows and exits completely, without any error message, when selecting the "Print window" menu command.
Starting IDLE from inside a console, one can see the error message:
It is trying to read this entry from the config-main.def file:
[General]
print-command-posix=lpr %s
print-command-win=start /min notepad /p %s
For a ConfigParser file, those %s should be %%s instead. Previous IDLE versions (2.7 and 3.1) read the same entry without problem; I suspect they were using a RawConfigParser or processing the entry in a different way.
As a workaround, replacing %s with %%s in config-main.def is enough, until the code gets fixed.
ggenellina commentedon Jun 7, 2011
Note: There is a much bigger problem here: IDLE should not abort abruptly in such cases, without any error indication.
python-dev commentedon Jun 7, 2011
New changeset 0aa3064d1cef by Łukasz Langa in branch '3.2':
bpo-12274: use proper escaping for % in IDLE config.
http://hg.python.org/cpython/rev/0aa3064d1cef
New changeset b410d013e7a8 by Łukasz Langa in branch 'default':
bpo-12274: use proper escaping for % in IDLE config (merged from 3.2).
http://hg.python.org/cpython/rev/b410d013e7a8
ambv commentedon Jun 7, 2011
In 3.2 configparser started validating syntax in interpolation-aware parsers by default. I fixed the configuration.
It's unfortunate this configuration error hasn't been caught before in testing. We need a unit test for broken configuration and a change in IDLE so that it doesn't silently crash when configuration is invalid.
BreamoreBoy commentedon Jun 8, 2014
Can this be closed as a patch has been committed and the unittest framework was created on bpo-15392 ?
terryjreedy commentedon Jun 8, 2014
This issue needs a unittest test added within the framework. I opened bpo-21696 as a dependency. Since configx.def files can be edited, and, I believe, at least one is intended to be edited, configHandler should perhaps catch exceptions and display in a messagebox. But unless Idle could continue after that, that might wait for the general fix, which is another issue.
terryjreedy commentedon Oct 2, 2014
Closing since the immediate problem has been fixed and there is a reference to this in bpo-21696