Skip to content

Enforce PEP 11 - remove support for legacy systems #56072

Closed
Closed
Enforce PEP 11 - remove support for legacy systems#56072
Labels
buildThe build process and cross-buildeasyinterpreter-core(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancement

Description

@pitrou
pitrou
opened on Apr 18, 2011
BPO 11863
Nosy @brettcannon, @jcea, @pitrou, @vstinner, @merwok
Files
  • remove_threads.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2011-07-08.21:55:35.385>
created_at = <Date 2011-04-18.00:08:57.309>
labels = ['interpreter-core', 'easy', 'type-feature', 'build']
title = 'Enforce PEP 11 - remove support for legacy systems'
updated_at = <Date 2011-07-08.21:55:35.385>
user = 'https://github.com/pitrou'

    bugs.python.org fields:

    activity = <Date 2011-07-08.21:55:35.385>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2011-07-08.21:55:35.385>
closer = 'pitrou'
components = ['Build', 'Interpreter Core']
creation = <Date 2011-04-18.00:08:57.309>
creator = 'pitrou'
dependencies = []
files = ['21722']
hgrepos = []
issue_num = 11863
keywords = ['patch', 'easy']
message_count = 9.0
messages = ['133944', '133947', '134051', '134058', '134060', '134101', '134103', '140040', '140042']
nosy_count = 6.0
nosy_names = ['brett.cannon', 'jcea', 'pitrou', 'vstinner', 'eric.araujo', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue11863'
versions = ['Python 3.3']

    Activity

    1. pitrou commented on Apr 18, 2011

      @pitrou
      pitrou
      on Apr 18, 2011
      MemberAuthor

      PEP-11 calls for removing support for the following systems in 3.3:

      Name:             Systems using Mach C Threads
Unsupported in:   Python 3.2
Code removed in:  Python 3.3

Name:             SunOS lightweight processes (LWP)
Unsupported in:   Python 3.2
Code removed in:  Python 3.3

Name:             Systems using --with-pth (GNU pth threads)
Unsupported in:   Python 3.2
Code removed in:  Python 3.3

Name:             Systems using Irix threads
Unsupported in:   Python 3.2
Code removed in:  Python 3.3

Name:             OSF* systems (bpo-8606)
Unsupported in:   Python 3.2 
Code removed in:  Python 3.3
    2. pitrou
      added
      buildThe build process and cross-build
      interpreter-core(Objects, Python, Grammar, and Parser dirs)
      easy
      type-featureA feature request or enhancement
      on Apr 18, 2011

    3. jcea commented on Apr 18, 2011

      @jcea
      jcea
      on Apr 18, 2011
      Member

      I think I toke care of OSF cleanup already.

    4. vstinner commented on Apr 19, 2011

      @vstinner
      vstinner
      on Apr 19, 2011
      Member

      Issue bpo-11876 has been marked as a duplicate of this issue.

    5. vstinner commented on Apr 19, 2011

      @vstinner
      vstinner
      on Apr 19, 2011
      Member

      Patch removing cpthread, pth, lwp and solaris thread implementations. The patch on configure.in, around the following diff, is invalid:
      ----

           AC_DEFINE(_REENTRANT)
-    AC_CHECK_HEADER(cthreads.h, [AC_DEFINE(WITH_THREAD)
-    AC_DEFINE(C_THREADS)
-    AC_DEFINE(HURD_C_THREADS, 1,
-    [Define if you are using Mach cthreads directly under /include])
-    LIBS="$LIBS -lthreads"
-    THREADOBJ="Python/thread.o"],[
-    AC_CHECK_HEADER(mach/cthreads.h, [AC_DEFINE(WITH_THREAD)
-    AC_DEFINE(C_THREADS)
-    AC_DEFINE(MACH_C_THREADS, 1,
-    [Define if you are using Mach cthreads under mach /])
-    THREADOBJ="Python/thread.o"],[
     # Just looking for pthread_create in libpthread is not enough:
     # on HP/UX, pthread.h renames pthread_create to a different symbol name.
     # So we really have to include pthread.h, and then link.

      autoconf will have to be run to update configure.

      I am not sure that the patch removes all code related to these threads.

    6. vstinner commented on Apr 19, 2011

      @vstinner
      vstinner
      on Apr 19, 2011
      Member

      FYI Hurd only supports cthread, without cthread support, Python will not support threads on Hurd anymore.

      There are two Hurd issues to move from cthread to pthread
      http://savannah.gnu.org/task/?5487 (opened 5 years ago)
      http://savannah.gnu.org/task/?7895 (opened 3 years ago)

    7. vstinner commented on Apr 19, 2011

      @vstinner
      vstinner
      on Apr 19, 2011
      Member

      Python/thread.c contains a reference to a missing file:

      #ifdef PLAN9_THREADS
#include "thread_plan9.h"
#endif

      But I don't see where PLAN9_THREADS is defined.

      remove_threads.patch removes these 3 lines.

      --

      There is also an unused file: Python/thread_wince.c. Can it be removed?

    8. pitrou commented on Apr 19, 2011

      @pitrou
      pitrou
      on Apr 19, 2011
      MemberAuthor

      Python/thread.c contains a reference to a missing file:

      #ifdef PLAN9_THREADS
      #include "thread_plan9.h"
      #endif

      But I don't see where PLAN9_THREADS is defined.

      remove_threads.patch removes these 3 lines.

      --

      There is also an unused file: Python/thread_wince.c. Can it be removed?

      +1 to both.

    9. python-dev commented on Jul 8, 2011

      @python-dev
      python-devmannequin
      on Jul 8, 2011
      Mannequin

      New changeset 638039a4fef3 by Antoine Pitrou in branch 'default':
      Issue bpo-11863: remove unused file Python/thread_wince.h
      http://hg.python.org/cpython/rev/638039a4fef3

    10. python-dev commented on Jul 8, 2011

      @python-dev
      python-devmannequin
      on Jul 8, 2011
      Mannequin

      New changeset 0aa3f90f0830 by Antoine Pitrou in branch 'default':
      Issue bpo-11863: Remove support for legacy systems deprecated in Python 3.2
      http://hg.python.org/cpython/rev/0aa3f90f0830

    11. pitrou
      closed this as completedon Jul 8, 2011
    12. ezio-melotti
      transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      buildThe build process and cross-buildeasyinterpreter-core(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancement

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions