You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Patch to IDLE for Python 2.7, at Guido's request #54346
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee=Noneclosed_at=<Date2010-10-19.04:29:26.896>created_at=<Date2010-10-18.15:54:04.316>labels= ['expert-IDLE', 'type-bug']
title="Patch to IDLE for Python 2.7, at Guido's request"updated_at=<Date2010-10-19.04:29:26.895>user='https://bugs.python.org/BruceSherwood'
At Guido's request, I've carried out the same update to the IDLE
distributed with Python 2.7 that I submitted for Python 3, to incorporate the work of Guilherme Polo in the Google Summer of Code 2009. Guido was concerned that with significant problems reported for IDLE 2.7, there should be an update despite Python 2.7 itself being essentially frozen. The basic structure for IDLE 3.2 was carried over. The main changes that had to be made were the change in module names between Python 2.7 and Python 3.2 (e.g. Tkinter in 2.7 is tkinter in 3.2).
But this patch is a diff between a 2.7 and a 3.2 version of IDLE, isn't it? The tkinter->Tkinter renaming is not supposed to happen in the 2.7 branch.
Could you instead show a diff between the present version of IDLE in 2.7 and the result of your work, so we can better see the impact of the change?
I believe the enhancements here are the same as submitted for py3k in bpo-10079. Since it is likely the same comments will apply to both variants, I think it would be better to have just one issue, so I would recommend regenerating the patch against the current 2.7 svn top of trunk (or the 2.7 release), attaching the patch to bpo-10079, and closing this as a duplicate.
Bruce, what Ned suggests is what I intended with my IDLE-list message, and in accord with usual tracker practice. Issues often apply to multiple versions and thereby require multiple patches and commits. I know you are relatively new at this and very much appreciate you pushing this IDLE update.
BruceSherwood commented on Oct 18, 2010
BruceSherwoodmannequin
MannequinAuthor
More actions
Perhaps I've used misleadingt terminology. What I meant is that I did
do a diff between IDLE 2.7 and the result of Guilherme Polo's work,
but the latter code started from Python 3 code and was modified as
needed for 2.7 (e.g. renaming tkinter as Tkinter, etc.) before
generating the patch.
But this patch is a diff between a 2.7 and a 3.2 version of IDLE, isn't it? The tkinter->Tkinter renaming is not supposed to happen in the 2.7 branch.
Could you instead show a diff between the present version of IDLE in 2.7 and the result of your work, so we can better see the impact of the change?
Activity
BruceSherwood commentedon Oct 18, 2010
At Guido's request, I've carried out the same update to the IDLE
distributed with Python 2.7 that I submitted for Python 3, to incorporate the work of Guilherme Polo in the Google Summer of Code 2009. Guido was concerned that with significant problems reported for IDLE 2.7, there should be an update despite Python 2.7 itself being essentially frozen. The basic structure for IDLE 3.2 was carried over. The main changes that had to be made were the change in module names between Python 2.7 and Python 3.2 (e.g. Tkinter in 2.7 is tkinter in 3.2).
amauryfa commentedon Oct 18, 2010
But this patch is a diff between a 2.7 and a 3.2 version of IDLE, isn't it? The tkinter->Tkinter renaming is not supposed to happen in the 2.7 branch.
Could you instead show a diff between the present version of IDLE in 2.7 and the result of your work, so we can better see the impact of the change?
ned-deily commentedon Oct 18, 2010
I believe the enhancements here are the same as submitted for py3k in bpo-10079. Since it is likely the same comments will apply to both variants, I think it would be better to have just one issue, so I would recommend regenerating the patch against the current 2.7 svn top of trunk (or the 2.7 release), attaching the patch to bpo-10079, and closing this as a duplicate.
terryjreedy commentedon Oct 18, 2010
Bruce, what Ned suggests is what I intended with my IDLE-list message, and in accord with usual tracker practice. Issues often apply to multiple versions and thereby require multiple patches and commits. I know you are relatively new at this and very much appreciate you pushing this IDLE update.
BruceSherwood commentedon Oct 18, 2010
Perhaps I've used misleadingt terminology. What I meant is that I did
do a diff between IDLE 2.7 and the result of Guilherme Polo's work,
but the latter code started from Python 3 code and was modified as
needed for 2.7 (e.g. renaming tkinter as Tkinter, etc.) before
generating the patch.
Bruce Sherwood
On Mon, Oct 18, 2010 at 11:44 AM, Amaury Forgeot d'Arc
<report@bugs.python.org> wrote:
BruceSherwood commentedon Oct 19, 2010
I've rebuilt and resubmitted this patch to bpo-10079 as requested by Ned Deily. This issue (10137) can now be labeled a duplicate.