PyUnicode_FromFormatV handles %R and %S incorrectly. #51857

Activity

1. avassalotti commented on Dec 30, 2009

   

   avassalotti

   on Dec 30, 2009

   MemberAuthor

   More actions

   It seems PyUnicode_FromFormatV wrongly assumes that the return value of
   PyObject_Str and PyObject_Repr is a unicode object. It looks like the
   %S and %R feature was backported from 3.x without updating the code for 2.x.

   PyObject *
   PyUnicode_FromFormatV(const char *format, va_list vargs)
   {
   ...
               case 'S':
               {
                   PyObject *obj = va_arg(count, PyObject *);
                   PyObject *str;
                   assert(obj);
                   str = PyObject_Str(obj);
                   if (!str)
                       goto fail;
                   n += PyUnicode_GET_SIZE(str);
                   /* Remember the str and switch to the next slot */
                   *callresult++ = str;
                   break;
               }
               case 'R':
               {
                   PyObject *obj = va_arg(count, PyObject *);
                   PyObject *repr;
                   assert(obj);
                   repr = PyObject_Repr(obj);
                   if (!repr)
                       goto fail;
                   n += PyUnicode_GET_SIZE(repr);
                   /* Remember the repr and switch to the next slot */
                   *callresult++ = repr;
                   break;
               }
   ...
   }
2. avassalotti

   added

   interpreter-core(Objects, Python, Grammar, and Parser dirs)(Objects, Python, Grammar, and Parser dirs)

   stdlibStandard Library Python modules in the Lib/ directoryStandard Library Python modules in the Lib/ directory

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Dec 30, 2009
3. avassalotti

   closed this as completedon Dec 30, 2009
4. ezio-melotti

   transferred this issue fromon Apr 10, 2022