Repository navigation
idlelib/rpc.py missing exit status on exithook #50898
Description
| BPO | 6649 |
|---|---|
| Nosy | @terryjreedy, @serwy, @serhiy-storchaka |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/serwy'
closed_at = <Date 2013-03-31.06:20:57.139>
created_at = <Date 2009-08-05.16:21:07.220>
labels = ['expert-IDLE', 'type-bug']
title = 'idlelib/rpc.py missing exit status on exithook'
updated_at = <Date 2013-04-07.07:23:21.998>
user = 'https://bugs.python.org/gpolo'bugs.python.org fields:
activity = <Date 2013-04-07.07:23:21.998>
actor = 'serhiy.storchaka'
assignee = 'roger.serwy'
closed = True
closed_date = <Date 2013-03-31.06:20:57.139>
closer = 'roger.serwy'
components = ['IDLE']
creation = <Date 2009-08-05.16:21:07.220>
creator = 'gpolo'
dependencies = []
files = ['14658']
hgrepos = []
issue_num = 6649
keywords = ['patch']
message_count = 5.0
messages = ['91322', '158295', '185616', '185617', '186180']
nosy_count = 5.0
nosy_names = ['terry.reedy', 'gpolo', 'roger.serwy', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue6649'
versions = ['Python 2.7', 'Python 3.3', 'Python 3.4']
Activity
gpolo commentedon Aug 5, 2009
SocketIO.exithook on idlelib/rpc.py is missing the exit status, this is
a minor issue since both client and server used on IDLE override this
method to do something else.
serwy commentedon Apr 14, 2012
The existing code will raise an error since os._exit requires an argument. http://docs.python.org/library/os.html#os.\_exit
The patch looks good to me.
python-dev commentedon Mar 31, 2013
New changeset e044d22d2f61 by Roger Serwy in branch '2.7':
bpo-6649: Fixed missing exit status in IDLE. Patch by Guilherme Polo.
http://hg.python.org/cpython/rev/e044d22d2f61
New changeset cd2c613527ed by Roger Serwy in branch '3.3':
bpo-6649: Fixed missing exit status in IDLE. Patch by Guilherme Polo.
http://hg.python.org/cpython/rev/cd2c613527ed
New changeset abbbe1f90635 by Roger Serwy in branch 'default':
bpo-6649: merge with 3.3.
http://hg.python.org/cpython/rev/abbbe1f90635
serwy commentedon Mar 31, 2013
Thanks for the patch, Guilherme!
serhiy-storchaka commentedon Apr 7, 2013
Congratulation with your first CPython commit, Roger!