Repository navigation
python3.0 interpreter on Cygwin ignores all arguments #47876
Description
| BPO | 3626 |
|---|---|
| Nosy | @loewis, @amauryfa, @pitrou, @tiran |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2008-10-30.23:03:58.824>
created_at = <Date 2008-08-21.04:36:00.252>
labels = ['interpreter-core', 'type-bug', 'release-blocker']
title = 'python3.0 interpreter on Cygwin ignores all arguments'
updated_at = <Date 2008-10-30.23:03:58.729>
user = 'https://bugs.python.org/yselkowitz'bugs.python.org fields:
activity = <Date 2008-10-30.23:03:58.729>
actor = 'amaury.forgeotdarc'
assignee = 'none'
closed = True
closed_date = <Date 2008-10-30.23:03:58.824>
closer = 'amaury.forgeotdarc'
components = ['Interpreter Core']
creation = <Date 2008-08-21.04:36:00.252>
creator = 'yselkowitz'
dependencies = []
files = ['11186', '11534', '11823']
hgrepos = []
issue_num = 3626
keywords = ['patch']
message_count = 22.0
messages = ['71606', '71617', '71690', '72020', '72029', '72042', '72044', '72413', '72415', '73474', '73475', '73479', '73519', '73520', '73522', '74905', '74937', '74942', '74960', '74993', '75280', '75398']
nosy_count = 5.0
nosy_names = ['loewis', 'amaury.forgeotdarc', 'pitrou', 'christian.heimes', 'yselkowitz']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue3626'
versions = ['Python 3.0']
Activity
amauryfa commentedon Sep 20, 2008
This patches corrects the bad printf, when the given filename is only
1-char long.
amauryfa commentedon Sep 20, 2008
Since the bsddb module has been removed from py3k, the previous patch
addresses the last issue for this ticket.
yselkowitz commentedon Sep 21, 2008
3.0rc1 together with the printf patch builds and installs. Some quick
testing seems ok, but idle isn't working:
IDLE appears briefly with a message:
Subprocess Startup Error
IDLE's subprocess didn't make connection. Either IDLE can't start a
subprocess or personal firewall software is blocking the connection.
[OK]
Pushing OK causes idle3.0 to quit. idle 2.5 works fine.
amauryfa commentedon Sep 21, 2008
The IDLE problem is already corrected: see bpo-3628.
yselkowitz commentedon Sep 21, 2008
In that case, then I think this can be closed; if I encounter any
further issues after rc2, I'll open a new bug.
Thank you for all your help.
amauryfa commentedon Sep 21, 2008
Well, after the proposed patch "cygwin_badprintf.patch" is reviewed and
applied...
loewis commentedon Oct 17, 2008
I think cygwin_badprintf.patch needs to consider the case r==PATH_MAX;
this happens when the conversion would need more than PATH_MAX bytes for
the target buffer. In that case, I think it would be good enough to
write "<file name too long>" into cfilename (using cfilename as is will
crash because it's not null-terminated; forcefully null-terminating it
might break the shift state)
amauryfa commentedon Oct 17, 2008
Updated patch, which checks the return value of wcstombs.
loewis commentedon Oct 17, 2008
IIUC, another error return value (besides -1) is PATH_MAX, meaning that
the buffer would overrun; correct me if I'm wrong. If I'm not, I propose
that they get handles similarly.
In addition, it might be safer to compare to (size_t)-1 (I keep
forgetting whether this is the default when comparing signed and
unsigned - some compilers warn about comparisong with mixed signs).
pitrou commentedon Oct 18, 2008
The patch looks sound to me. Someone should probably test it under
Cygwin.
yselkowitz commentedon Oct 20, 2008
3.0rc1 builds and installs fine with the latest patch. Thanks!
tiran commentedon Oct 28, 2008
I can't reproduce the problem with my installation of Cygwin on Windows
XP. However the patch doesn't cause problems so you might apply it.
amauryfa commentedon Oct 30, 2008
Committed the "%ls" fix with r67064.