Repository navigation
TimedRotatingFileHandler crashes on backup file deletion attempt #47178
Description
| BPO | 2929 |
|---|---|
| Nosy | @vsajip |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/vsajip'
closed_at = <Date 2008-05-20.15:43:08.795>
created_at = <Date 2008-05-20.12:34:09.194>
labels = ['library', 'type-crash']
title = 'TimedRotatingFileHandler crashes on backup file deletion attempt'
updated_at = <Date 2008-05-20.15:43:08.794>
user = 'https://bugs.python.org/blocki'bugs.python.org fields:
activity = <Date 2008-05-20.15:43:08.794>
actor = 'vinay.sajip'
assignee = 'vinay.sajip'
closed = True
closed_date = <Date 2008-05-20.15:43:08.795>
closer = 'vinay.sajip'
components = ['Library (Lib)']
creation = <Date 2008-05-20.12:34:09.194>
creator = 'blocki'
dependencies = []
files = []
hgrepos = []
issue_num = 2929
keywords = []
message_count = 2.0
messages = ['67125', '67131']
nosy_count = 2.0
nosy_names = ['vinay.sajip', 'blocki']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue2929'
versions = ['Python 2.5']
Activity
blocki commentedon May 20, 2008
Hello,
when the maximum number of backup files is reached
TimedRotatingFileHandler can't delete the oldest existing file. I got
the following error message:
The reason for this error is located in the getFilesToDelete method of
the TimedRotatingFileHandler class. The result sequence of this method
contains filenames but a complete filepath is needed.
After replacing
result.append(fileName)
with
result.append(os.path.join(dirName, fileName))
the problem seems to be solved
Regards
Stephan
vsajip commentedon May 20, 2008
Fix checked into trunk (r63507). Thanks for the report!