Repository navigation
Remove commands for PEP 3108 #47121
Description
| BPO | 2872 |
|---|---|
| Nosy | @brettcannon, @benjaminp |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/brettcannon'
closed_at = <Date 2008-05-26.21:31:36.206>
created_at = <Date 2008-05-16.04:37:25.606>
labels = ['type-bug', 'library', 'release-blocker']
title = 'Remove commands for PEP 3108'
updated_at = <Date 2008-05-26.21:31:36.205>
user = 'https://github.com/brettcannon'bugs.python.org fields:
activity = <Date 2008-05-26.21:31:36.205>
actor = 'benjamin.peterson'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2008-05-26.21:31:36.206>
closer = 'benjamin.peterson'
components = ['Library (Lib)']
creation = <Date 2008-05-16.04:37:25.606>
creator = 'brett.cannon'
dependencies = []
files = ['10413', '10414', '10444']
hgrepos = []
issue_num = 2872
keywords = ['patch']
message_count = 10.0
messages = ['66894', '67154', '67229', '67230', '67231', '67382', '67384', '67389', '67395', '67397']
nosy_count = 3.0
nosy_names = ['brett.cannon', 'quentin.gallet-gilles', 'benjamin.peterson']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue2872'
versions = ['Python 2.6', 'Python 3.0']
Activity
brettcannon commentedon May 16, 2008
The commands module is slated to go. The getstatus() function needs to be
deprecated, with the rest of the module moving into subprocess (and thus
adding commands to the 2to3 fix_import fixer).
quentingallet-gilles commentedon May 21, 2008
I'm working on it.
quentingallet-gilles commentedon May 23, 2008
Ok, here are the patches. Since it's a combination of renaming and
removing, I had to improvize a little, particularly in the 2.6
documentation. Hope it's done correctly.
I still have doubts about the following issue, as commented in
test_commands.py :
# The module says:
# "NB This only works (and is only relevant) for UNIX."
# Actually, getoutput should work on any platform with an os.popen, but
# I'll take the comment as given, and skip this suite.
I played it safe as well and didn't change the platform test (both in
trunk/test_py3kwarn and py3k/test_subprocess). Should this restriction
remain ?
quentingallet-gilles commentedon May 23, 2008
Ok, here are the patches. Since it's a combination of renaming and
removing, I had to improvise a little (particularly in the 2.6
documentation). Hope it's done correctly.
I still have doubts about the following issue. As commented in
test_commands.py:
# The module says:
# "NB This only works (and is only relevant) for UNIX."
# Actually, getoutput should work on any platform with an os.popen, but
# I'll take the comment as given, and skip this suite.
I also decided to play it safe and didn't change the test (both in
trunk/test_py3kwarn and py3k/test_subprocess). Should this restriction
remain?
quentingallet-gilles commentedon May 23, 2008
Sorry for the double post
brettcannon commentedon May 26, 2008
r63715 has the 3.0 changes; biggest difference is that I also ripped out
the mk2arg() and friends since they are not used by anyone.
I still need to add the fixer and add the proper warnings in 2.6 along
with the doc change.
benjaminp commentedon May 26, 2008
2.6 things done in r63721.
brettcannon commentedon May 26, 2008
Thanks for adding the warnings, Benjamin. The docs for 2.6 still need to
be updated about the rename/merge. I have replied to your commit with some
comments.
And I think the 2to3 fixer still needs to be done. Because of all this I
am re-opening this issue.
quentingallet-gilles commentedon May 26, 2008
I've updated the 2to3 import fixer (mkarg/mk2arg not handled anymore).
benjaminp commentedon May 26, 2008
I've committed Quentin's 2to3 addition as r63729.