Repository navigation
2to3 fixer to rename markupbase to _markupbase #47110
Description
| BPO | 2861 |
|---|---|
| Nosy | @brettcannon |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2008-05-22.03:19:02.392>
created_at = <Date 2008-05-15.09:42:14.039>
labels = ['type-bug', 'expert-2to3', 'release-blocker']
title = '2to3 fixer to rename markupbase to _markupbase'
updated_at = <Date 2008-05-22.06:51:04.988>
user = 'https://bugs.python.org/quentingallet-gilles'bugs.python.org fields:
activity = <Date 2008-05-22.06:51:04.988>
actor = 'quentin.gallet-gilles'
assignee = 'collinwinter'
closed = True
closed_date = <Date 2008-05-22.03:19:02.392>
closer = 'brett.cannon'
components = ['2to3 (2.x to 3.x conversion tool)']
creation = <Date 2008-05-15.09:42:14.039>
creator = 'quentin.gallet-gilles'
dependencies = []
files = ['10388']
hgrepos = []
issue_num = 2861
keywords = ['patch']
message_count = 9.0
messages = ['66850', '66851', '66853', '66875', '67087', '67108', '67151', '67178', '67181']
nosy_count = 3.0
nosy_names = ['brett.cannon', 'collinwinter', 'quentin.gallet-gilles']
pr_nums = []
priority = 'release blocker'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue2861'
versions = ['Python 3.0']
Activity
quentingallet-gilles commentedon May 15, 2008
Before applying the attached patch, the command 'svn move
Lib/markupbase.py Lib/_markupbase.py" must be invoked.
Little reminder : since the changes are already applied in the 3.0
codebase, the patch should also be blocked from the py3k branch.
I'll also add another patch with the 2to3 import fixer.
quentingallet-gilles commentedon May 15, 2008
Updated patch : I forgot to add a check in test___all__
quentingallet-gilles commentedon May 15, 2008
Actually, the test___all__ check is an error since _markupbase has no
__all__ attribute. I've restored the first version of the patch.
brettcannon commentedon May 15, 2008
Added as a dependency on bpo-2775 so as to not lose this patch.
brettcannon commentedon May 20, 2008
This does not need to happen in 2.6; only 3.0.
quentingallet-gilles commentedon May 20, 2008
I'll update the patches to reflect that.
quentingallet-gilles commentedon May 21, 2008
Well, there's only the fixer to apply.
[-]Patch to rename markupbase to _markupbase[/-][+]2to3 fixer to rename markupbase to _markupbase[/+]brettcannon commentedon May 22, 2008
Applied in r63533 to 2to3 in the fixer. I also added you, Quentin to
Misc/ACKS in the trunk.
quentingallet-gilles commentedon May 22, 2008
Thanks Brett. About the Misc/ACKS file I promise I'll contribute more than
just an import fixer !
On Thu, May 22, 2008 at 5:19 AM, Brett Cannon <report@bugs.python.org>
wrote: