Add gestalt back into Python 3.0 #47103
Description
| BPO | 2854 |
|---|---|
| Nosy | @brettcannon, @benjaminp |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/benjaminp'
closed_at = <Date 2008-05-29.21:25:47.692>
created_at = <Date 2008-05-14.20:09:37.575>
labels = ['type-bug', 'library', 'release-blocker']
title = 'Add gestalt back into Python 3.0'
updated_at = <Date 2008-05-29.21:25:47.670>
user = 'https://github.com/brettcannon'bugs.python.org fields:
activity = <Date 2008-05-29.21:25:47.670>
actor = 'benjamin.peterson'
assignee = 'benjamin.peterson'
closed = True
closed_date = <Date 2008-05-29.21:25:47.692>
closer = 'benjamin.peterson'
components = ['Library (Lib)']
creation = <Date 2008-05-14.20:09:37.575>
creator = 'brett.cannon'
dependencies = []
files = ['10336', '10370']
hgrepos = []
issue_num = 2854
keywords = ['patch']
message_count = 9.0
messages = ['66828', '66831', '66832', '66836', '66837', '66838', '66878', '67076', '67512']
nosy_count = 2.0
nosy_names = ['brett.cannon', 'benjamin.peterson']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue2854'
versions = ['Python 3.0']
Activity
brettcannon commentedon May 14, 2008
gestalt was removed as part of the stdlib cleanup for Mac code. But it
turns out that gestalt is one of those modules that is just needed. Either
the original version needs to be added back in or a ctypes version needs
to be implemented. Either way, something to get system info needs to be
added back into the stdlib (and probably go into plat-darwin).
brettcannon commentedon May 14, 2008
Actually, the plat-darwin comment is not right if the original C version
is kept since that would just end up in Modules.
benjaminp commentedon May 14, 2008
Does it have to be public? How about _gestalt?
brettcannon commentedon May 14, 2008
On Wed, May 14, 2008 at 1:37 PM, Benjamin Peterson
<report@bugs.python.org> wrote:
That's fine by me. If someone really cares enough they can document it
themselves.
benjaminp commentedon May 15, 2008
I feel kinda bad about removing the module without noting how it was
used in platform.py, so I'll deal with this.
brettcannon commentedon May 15, 2008
On Wed, May 14, 2008 at 6:01 PM, Benjamin Peterson
<report@bugs.python.org> wrote:
While I am not going to stop you dealing with it, you shouldn't feel
bad. It would have been best had a test case in test_platform picked
this up (if you can it would be great to toss a test in).
benjaminp commentedon May 15, 2008
Here's a patch. I moved gestalt to Modules and renamed it _gestalt. I
inlined the few lines of pymactoolbox that I needed, so that doesn't
have to come back.
benjaminp commentedon May 19, 2008
This is just a reminder to myself that when this is checked in, I need
to unblock and merge r63460 and r63464.
benjaminp commentedon May 29, 2008
_gestalt was added in 63795.