Repository navigation
Remove usage of rfc822 from the stdlib #47098
Description
| BPO | 2849 |
|---|---|
| Nosy | @warsaw, @brettcannon, @hdiogenes, @benjaminp |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2008-06-12.22:16:12.045>
created_at = <Date 2008-05-14.01:02:03.662>
labels = ['type-bug', 'library']
title = 'Remove usage of rfc822 from the stdlib'
updated_at = <Date 2008-06-12.22:16:12.043>
user = 'https://github.com/brettcannon'bugs.python.org fields:
activity = <Date 2008-06-12.22:16:12.043>
actor = 'benjamin.peterson'
assignee = 'none'
closed = True
closed_date = <Date 2008-06-12.22:16:12.045>
closer = 'benjamin.peterson'
components = ['Library (Lib)']
creation = <Date 2008-05-14.01:02:03.662>
creator = 'brett.cannon'
dependencies = []
files = ['10375', '10376', '10494']
hgrepos = []
issue_num = 2849
keywords = ['patch']
message_count = 12.0
messages = ['66810', '67055', '67056', '67057', '67569', '67597', '67626', '67642', '68046', '68083', '68091', '68103']
nosy_count = 4.0
nosy_names = ['barry', 'brett.cannon', 'hdiogenes', 'benjamin.peterson']
pr_nums = []
priority = 'critical'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue2849'
versions = ['Python 2.6', 'Python 3.0']
Activity
brettcannon commentedon May 14, 2008
The rfc822 module has been deprecated for a while but is still used in the
stdlib (at least in 'cgi' and 'test_urllib2'). All uses need to go before
the module can be removed.
hdiogenes commentedon May 19, 2008
A quick search for rfc822 imports in py3k reveals this:
The real "release blockers" should be cgi, mimetools and test_urllib2.
hdiogenes commentedon May 19, 2008
Correction: mimetools is also being removed from py3k (bpo-2848).
hdiogenes commentedon May 19, 2008
Tried to just replace rfc822.Message with email.message_from_file in
cgi.py but it didn't work. I still have to figure out how to fix
FieldStorage.read_multi.
hdiogenes commentedon May 31, 2008
Seems that removing rfc822 from
cgiis not an easy task -- please see bpo-1112856.hdiogenes commentedon Jun 1, 2008
Added a patch that successfully removes rfc822 dependency from the cgi
module, using ideas from bpo-1112856. I had to change one test, as the
email FeedParser ignores trailing spaces in subparts.
hdiogenes commentedon Jun 2, 2008
With the attached patches, rfc822 won't be used anywhere inside Lib/
anymore (with the exception of mimetools, which is going away too).
Is there any reason to convert the files below? Shouldn't they be removed
from 3.0?
Demo/scripts/mboxconvert.py -> superseded by mailbox.py
Tools/faqwiz/faqwiz.py -> really old (1998)
Tools/scripts/mailerdaemon.py -> still useful?
Tools/versioncheck/pyversioncheck.py -> really old (1997)
brettcannon commentedon Jun 2, 2008
On Sun, Jun 1, 2008 at 8:33 PM, Humberto Diogenes
<report@bugs.python.org> wrote:
Probably. I bet both the Demo and Tools directory need a thorough clean-up.
warsaw commentedon Jun 12, 2008
Reviewed and applied to Python 3.0 in r64161. The patch did not apply
cleanly for 2.6. I'm going to bump this down to critical for the first
betas. Humberto, can you back port it to Python 2.6?
hdiogenes commentedon Jun 12, 2008
[msg68060]
So, does it make sense to backport this too?
warsaw commentedon Jun 12, 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Jun 12, 2008, at 4:36 PM, Humberto Diogenes wrote:
No.
Thanks,
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)
iQCVAwUBSFGSL3EjvBPtnXfVAQLooAP+PQK6Q9p6lDbmLkBgbQio5CXdckssMMyI
yvj0DYvK5wBYCurCjOTZ5VFUQZTEloj6p/89qf3HScfUASlIie1vJJRUqCktPDLs
THBicAS9lUXWLhmrD6ADgaLN88JMlTGnzpe03vBpScgFfy3fp8QHBoMzjud38amn
ozB6lzB+mAQ=
=qHGu
-----END PGP SIGNATURE-----
benjaminp commentedon Jun 12, 2008
I've removed the whole module in r64203.