Repository navigation
rename test_support to support #46873
Description
| BPO | 2621 |
|---|---|
| Nosy | @loewis, @brettcannon, @birkenfeld, @benjaminp |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/benjaminp'
closed_at = <Date 2008-05-20.21:38:20.881>
created_at = <Date 2008-04-12.00:32:24.582>
labels = ['easy', 'type-feature', 'tests', 'release-blocker']
title = 'rename test_support to support'
updated_at = <Date 2008-05-20.22:09:32.204>
user = 'https://github.com/benjaminp'bugs.python.org fields:
activity = <Date 2008-05-20.22:09:32.204>
actor = 'brett.cannon'
assignee = 'benjamin.peterson'
closed = True
closed_date = <Date 2008-05-20.21:38:20.881>
closer = 'benjamin.peterson'
components = ['Tests']
creation = <Date 2008-04-12.00:32:24.582>
creator = 'benjamin.peterson'
dependencies = []
files = ['10014', '10015', '10018']
hgrepos = []
issue_num = 2621
keywords = ['patch', 'easy']
message_count = 12.0
messages = ['65385', '65392', '65396', '65403', '65597', '65598', '66301', '67086', '67110', '67124', '67137', '67138']
nosy_count = 4.0
nosy_names = ['loewis', 'brett.cannon', 'georg.brandl', 'benjamin.peterson']
pr_nums = []
priority = 'release blocker'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue2621'
versions = ['Python 3.0']
Activity
benjaminp commentedon Apr 12, 2008
I used some brute force search and replace for this and it worked quite
well. If this patch is accepted, I'll fix the docs.
loewis commentedon Apr 12, 2008
What's the rationale for this change?
birkenfeld commentedon Apr 12, 2008
It would be nice if all test.test_foo modules were real tests.
I know this is on the stdlib-sig's list of changes for 3.0; I don't
think we should do the rename in 2.x.
benjaminp commentedon Apr 12, 2008
Right, we should do this only in Py3k. It might be helpful to make an
alias in 2.6 for it. Attaching py3k patch.
benjaminp commentedon Apr 17, 2008
Brett, comments?
brettcannon commentedon Apr 18, 2008
I am going to assign this to me, but wait until Guido pronounces on PEP-3108 before moving forward with a review.
benjaminp commentedon May 6, 2008
Now that the stdlib-reorg PEP has been accepted, would you like you me
to apply this patch? (Of course, I'll account for recent changes in the
test suite.)
brettcannon commentedon May 20, 2008
No renames will occur in 2.6, only in 3.0, which means this can happen
whenever.
birkenfeld commentedon May 20, 2008
Should be safe to apply now, Benjamin.
benjaminp commentedon May 20, 2008
On Tue, May 20, 2008 at 2:33 AM, Georg Brandl <report@bugs.python.org> wrote:
Will do today.
Cheers,
Benjamin Peterson
"There's no place like 127.0.0.1."
benjaminp commentedon May 20, 2008
Done in r63512.
brettcannon commentedon May 20, 2008
I just added the note to the docs in 2.6.