Repository navigation
test_smtplib.py no longer butt slow #46675
Description
| BPO | 2423 |
|---|---|
| Nosy | @devdanzin |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2010-08-03.06:39:59.042>
created_at = <Date 2008-03-19.14:50:48.432>
labels = ['tests', 'performance']
title = 'test_smtplib.py no longer butt slow'
updated_at = <Date 2010-08-03.06:39:59.041>
user = 'https://bugs.python.org/jerryseutter'bugs.python.org fields:
activity = <Date 2010-08-03.06:39:59.041>
actor = 'richard'
assignee = 'richard'
closed = True
closed_date = <Date 2010-08-03.06:39:59.042>
closer = 'richard'
components = ['Tests']
creation = <Date 2008-03-19.14:50:48.432>
creator = 'jerry.seutter'
dependencies = []
files = ['9766', '9767']
hgrepos = []
issue_num = 2423
keywords = ['patch']
message_count = 4.0
messages = ['64058', '87913', '112424', '112556']
nosy_count = 3.0
nosy_names = ['richard', 'jerry.seutter', 'ajaksu2']
pr_nums = []
priority = 'low'
resolution = 'accepted'
stage = 'commit review'
status = 'closed'
superseder = None
type = 'performance'
url = 'https://bugs.python.org/issue2423'
versions = ['Python 3.2']
Activity
jerryseutter commentedon Mar 19, 2008
Changes only affect test files.
test_smtplib.py before: 39.7s
test_smtplib.py after: 0.8s
socket.getfqdn() calls were causing all the slowness. Added a
mock_socket.py file to handle some tests. For other tests that tested
both server side and client side of the smtp libraries, mocked out
socket.getfqdn() only.
devdanzin commentedon May 16, 2009
What platform is that? I'm sure I don't get such a long runtime for
test_smtplib on Linux. Maybe this was fixed by changes in socket or
smtplib itself?
richard commentedon Aug 2, 2010
The patch to test_smtplib.py no longer applies since trunk is now py3k. I'm looking into it - and seeing whether the mock socket work I implemented for test_smtpd.py will have any common code. I'm hitting some "fun" areas of py3k-ness with bytes/str stuff in smtplib at the moment though ;-)
richard commentedon Aug 3, 2010
Merged mock socket from test_smtpd.py and committed.