Skip to content

MozillaCookieJar does not support Firefox3 cookie files #46530

Closed

Description

@thekorn
mannequin
BPO 2277
Nosy @gpshead
Files
  • 2277_handling_FF3_cookies.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gpshead'
    closed_at = <Date 2008-08-04.03:55:55.042>
    created_at = <Date 2008-03-12.08:35:52.952>
    labels = ['type-feature', 'library']
    title = 'MozillaCookieJar does not support Firefox3 cookie files'
    updated_at = <Date 2010-07-12.18:14:25.508>
    user = 'https://bugs.python.org/thekorn'

    bugs.python.org fields:

    activity = <Date 2010-07-12.18:14:25.508>
    actor = 'jjlee'
    assignee = 'gregory.p.smith'
    closed = True
    closed_date = <Date 2008-08-04.03:55:55.042>
    closer = 'gregory.p.smith'
    components = ['Library (Lib)']
    creation = <Date 2008-03-12.08:35:52.952>
    creator = 'thekorn'
    dependencies = []
    files = ['9669']
    hgrepos = []
    issue_num = 2277
    keywords = ['patch']
    message_count = 5.0
    messages = ['63470', '63518', '69375', '70681', '110119']
    nosy_count = 5.0
    nosy_names = ['gregory.p.smith', 'jjlee', 'ghaering', 'thekorn', 'hongqn']
    pr_nums = []
    priority = 'normal'
    resolution = 'rejected'
    stage = None
    status = 'closed'
    superseder = None
    type = 'enhancement'
    url = 'https://bugs.python.org/issue2277'
    versions = ['Python 2.6']

    Activity

    1. thekorn commented on Mar 12, 2008

      thekornmannequin
      MannequinAuthor

      In Firefox 3 the cookies are stored in a sqlite database instead of a
      txt-file. It would be nice if cookielib.MozillaCookieJar().load() could
      support this.

      Markus

    2. thekorn commented on Mar 13, 2008

      thekornmannequin
      MannequinAuthor

      I had some time this evening and tried to create a patch.
      I don't know if such a solution makes sense nor do I know if this fits
      in the process of fixing bugs in python.

      Markus

    3. gpshead commented on Jul 7, 2008

      @gpshead
      Member

      sounds like a good idea to add this. yay firefox 3. i'll review it.

    4. added
      stdlibStandard Library Python modules in the Lib/ directory
      on Jul 7, 2008
    5. self-assigned this
      on Jul 7, 2008
    6. gpshead commented on Aug 4, 2008

      @gpshead
      Member

      Thanks. I've looked over your code. The logic looks good, however I'd
      like to propose a better design and that this not be included in 2.6.

      Instead of putting this functionality in the MozCookieJar class, it
      should be its own new Firefox3CookieJar class as it is an entirely new
      file format.

      A much better implementation could be made that actually works with the
      sqlite3 file as a database rather than taking ownership of it and
      deleting all cookies and rewriting the entire file on save:

      The FileCookieJar.delayload flag could now be honored.

      The save() method should only do the necessary update/insert/delete
      commands rather than rewriting everything.

      Its a bit late to get this into Python 2.6/3.0 as the final beta is due
      out next week. But thats fine. People who need to manipulate ff3
      cookie files can use sqlite directly and when a nicer FileCookieJar for
      them has been written we can consider including it in python 2.7/3.1.
      Until then it can be an external just like the the one for IE currently is.

    7. jjlee commented on Jul 12, 2010

      jjleemannequin
      Mannequin

      There is code in PyPI project mechanize that implements this feature. That code is marked experimental though, due to lack of testing.

    8. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    Labels

    stdlibStandard Library Python modules in the Lib/ directorytype-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions