Skip to content

py3k: correction for test_marshal on Windows #45391

Closed

Description

@amauryfa
BPO 1050
Nosy @gvanrossum, @amauryfa
Files
  • marshall.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2007-08-29.18:45:08.610>
    created_at = <Date 2007-08-29.00:05:54.097>
    labels = ['OS-windows']
    title = 'py3k: correction for test_marshal on Windows'
    updated_at = <Date 2007-08-29.18:45:08.609>
    user = 'https://github.com/amauryfa'

    bugs.python.org fields:

    activity = <Date 2007-08-29.18:45:08.609>
    actor = 'gvanrossum'
    assignee = 'none'
    closed = True
    closed_date = <Date 2007-08-29.18:45:08.610>
    closer = 'gvanrossum'
    components = ['Windows']
    creation = <Date 2007-08-29.00:05:54.097>
    creator = 'amaury.forgeotdarc'
    dependencies = []
    files = ['8351']
    hgrepos = []
    issue_num = 1050
    keywords = []
    message_count = 3.0
    messages = ['55391', '55392', '55431']
    nosy_count = 2.0
    nosy_names = ['gvanrossum', 'amaury.forgeotdarc']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue1050'
    versions = ['Python 3.0']

    Activity

    1. amauryfa commented on Aug 29, 2007

      @amauryfa
      ContributorAuthor

      On Windows, debug builds insert stack probes, and recursive functions
      tend to exhaust the stack faster.
      This patch reduces the marshal maximum depth from 2000 to 1500 for debug
      builds only. Optimized builds are not affected.

    2. amauryfa commented on Aug 29, 2007

      @amauryfa
      ContributorAuthor

      I forgot to say that this allows test_marshal to pass with debug builds.

    3. gvanrossum commented on Aug 29, 2007

      @gvanrossum
      Member

      Committed revision 57672.
      You'll have to watch the buildbots.

    4. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions