Skip to content

Add more tests for getpass #130524

Description

@donbarbos

This is something I thought of when working #130496, I noticed that some tests were missing.
Test Lib/test/test_getpass.py only has three classes: GetpassGetuserTest, GetpassRawinputTest, UnixGetpassTest.

This clearly doesn't cover all cases, I think we should add at least WinGetpassTest and check that both implementations (unix_getpass and win_getpass) work the same.

Linked PRs

Activity

  1. tomasr8 commented on Feb 24, 2025

    @tomasr8
    Member

    Just an FYI, the devguide has some information on how to systematically measure and increase test coverage: https://devguide.python.org/testing/coverage/

  2. jtranq commented on Feb 24, 2025

    @jtranq

    Can I work on this?

  3. donbarbos commented on Feb 25, 2025

    @donbarbos
    ContributorAuthor

    Can I work on this?

    yeah, i think so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsTests in the Lib/test dir

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions