Skip to content

Make condition inside codegen_addop_load_const a macro #129552

Closed
Closed
Make condition inside codegen_addop_load_const a macro#129552
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

Description

@WolframAlph
WolframAlph
opened on Feb 1, 2025

Bug report

Bug description:

We need to reuse this condition:

cpython/Python/codegen.c

Line 287 in 71ae933

if (!overflow && val >= 0 && val < 256 && val < _PY_NSMALLPOSINTS) {

in CFG. FTR: #129568 (comment).

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

Activity

  1. WolframAlph
    added
    type-bugAn unexpected behavior, bug, or error
    on Feb 1, 2025
  2. picnixz
    added
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    on Feb 1, 2025
  3. WolframAlph
    changed the title [-]Redundant condition inside `codegen_addop_load_const`[/-] [+]Make condition inside `codegen_addop_load_const` a macro[/+] on Feb 3, 2025

  4. WolframAlph commented on Feb 3, 2025

    @WolframAlph
    WolframAlph
    on Feb 3, 2025
    ContributorAuthor

    @picnixz , can you edit bug label, since this issue has changed?

  5. WolframAlph commented on Feb 3, 2025

    @WolframAlph
    WolframAlph
    on Feb 3, 2025
    ContributorAuthor

    Closing as this will be done as part of another issue.

  6. WolframAlph
    closed this as completedon Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    interpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions