Skip to content

_PyStaticType_InitBuiltin should not exist. #103276

Description

@markshannon

Part three in an ongoing series...

Following on from #96458 and #101603.

Static, builtin classes must be sharable across interpreters.
Therefore, they should be immortal and idempotent immutable. Ideally they should be immutable, but we can tolerate a bit of initialization as long as it is idempotent and thread-safe.
Therefore _PyStaticType_InitBuiltin should not exist.
We can also free up the _Py_TPFLAGS_STATIC_BUILTIN flag, as we are running low on flags.

AFAICT _PyStaticType_InitBuiltin sets an index for accessing the subclasses dict on the interpreter, and calls PyType_Ready. That's all.
PyType_Ready should be a no op on static builtin classes. (If it isn't, then that's another issue we need to add.)
Setting the subclass index can be done lazily, as many builtin classes are never subclassed.
There is no reason for the index to be distinct from the version tag, so we should use that, and statically initialize it for int, type, etc.

@ericsnowcurrently @kumaraditya303
Any more of these static init/dealloc functions? They should all go.

Activity

  1. ericsnowcurrently commented on Apr 5, 2023

    @ericsnowcurrently
    Member

    FWIW, everything you've said makes sense. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions