Skip to content

Should triage team members be allowed to "Approve GitHub Actions workflow run"? #423

Description

@sobolevn

Let's take this PR as an example: python/cpython#30493

A developer pushes some valid patch to CPython. But, no one from triage team can authenticate the GitHub Actions run.

Снимок экрана 2022-01-10 в 18 00 21

This leaves new contributors to wait longer and requires some attention from core-devs, wasting their time.

Maybe triagers should be able to do that? 🤔

Activity

  1. hugovk commented on Jan 10, 2022

    @hugovk
    Member

    https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks#approving-workflow-runs-on-a-pull-request-from-a-public-fork says:

    Maintainers with write access to a repository can use the following procedure to review and run workflows on pull requests from contributors that require approval.

    So sounds like only those with write access can approve it => only core devs.

  2. zware commented on Jan 26, 2022

    @zware
    Member

    To answer the question in the title: ideally, yes. However, as far as I know GitHub's permissions structure is not granular enough for us to have control over that, so I'm unfortunately just closing the issue.

    If there's somewhere to request this from GitHub, please do :)

  3. sobolevn commented on Jan 27, 2022

    @sobolevn
    MemberAuthor

    If there's somewhere to request this from GitHub, please do :)

    I have a direct access to GitHub feature request, consider it done! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions